[PATCH] Updated locking documentation for journal_head

[PATCH] Updated locking documentation for journal_head

[Alexander Lochmann]

LockDoc's results show that t_list_lock has been
replaced by j_list_lock for b_next_transaction,
b_tnext, and b_tprev.
We, therefore, updated the documentation
accordingly.

Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
---
 include/linux/journal-head.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
index 75bc56109031..d68ae72784eb 100644
--- a/include/linux/journal-head.h
+++ b/include/linux/journal-head.h
@@ -80,13 +80,13 @@ struct journal_head {
 	 * Pointer to the running compound transaction which is currently
 	 * modifying the buffer's metadata, if there was already a transaction
 	 * committing it when the new transaction touched it.
-	 * [t_list_lock] [b_state_lock]
+	 * [j_list_lock] [b_state_lock]
 	 */
 	transaction_t *b_next_transaction;
 
 	/*
 	 * Doubly-linked list of buffers on a transaction's data, metadata or
-	 * forget queue. [t_list_lock] [b_state_lock]
+	 * forget queue. [j_list_lock] [b_state_lock]
 	 */
 	struct journal_head *b_tnext, *b_tprev;
 
-- 
2.20.1

Re: [PATCH] Updated locking documentation for journal_head

[Jan Kara]

On Fri 19-03-21 10:18:17, Alexander Lochmann wrote:
> LockDoc's results show that t_list_lock has been
> replaced by j_list_lock for b_next_transaction,
> b_tnext, and b_tprev.
> We, therefore, updated the documentation
> accordingly.
> 
> Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>

Yeah, I think that was a typo since the beginning. Thanks for the fix. Feel
free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/journal-head.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 75bc56109031..d68ae72784eb 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -80,13 +80,13 @@ struct journal_head {
>  	 * Pointer to the running compound transaction which is currently
>  	 * modifying the buffer's metadata, if there was already a transaction
>  	 * committing it when the new transaction touched it.
> -	 * [t_list_lock] [b_state_lock]
> +	 * [j_list_lock] [b_state_lock]
>  	 */
>  	transaction_t *b_next_transaction;
>  
>  	/*
>  	 * Doubly-linked list of buffers on a transaction's data, metadata or
> -	 * forget queue. [t_list_lock] [b_state_lock]
> +	 * forget queue. [j_list_lock] [b_state_lock]
>  	 */
>  	struct journal_head *b_tnext, *b_tprev;
>  
> -- 
> 2.20.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

[PATCH v2] Updated locking documentation for journal_head

[Alexander Lochmann]

LockDoc's results show that t_list_lock has been
replaced by j_list_lock for b_next_transaction,
b_tnext, and b_tprev.
We, therefore, updated the documentation
accordingly.

Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 include/linux/journal-head.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
index 75bc56109031..d68ae72784eb 100644
--- a/include/linux/journal-head.h
+++ b/include/linux/journal-head.h
@@ -80,13 +80,13 @@ struct journal_head {
 	 * Pointer to the running compound transaction which is currently
 	 * modifying the buffer's metadata, if there was already a transaction
 	 * committing it when the new transaction touched it.
-	 * [t_list_lock] [b_state_lock]
+	 * [j_list_lock] [b_state_lock]
 	 */
 	transaction_t *b_next_transaction;
 
 	/*
 	 * Doubly-linked list of buffers on a transaction's data, metadata or
-	 * forget queue. [t_list_lock] [b_state_lock]
+	 * forget queue. [j_list_lock] [b_state_lock]
 	 */
 	struct journal_head *b_tnext, *b_tprev;
 
-- 
2.20.1

Re: [PATCH v2] Updated locking documentation for journal_head

[Alexander Lochmann]

[-- Attachment #1.1: Type: text/plain, Size: 1748 bytes --]

Hi folks,

Have you had the chance to review my patch?
Does is look good to you?
Jan already approved it.

Regards,
Alex


On 19.03.21 11:47, Alexander Lochmann wrote:
> LockDoc's results show that t_list_lock has been
> replaced by j_list_lock for b_next_transaction,
> b_tnext, and b_tprev.
> We, therefore, updated the documentation
> accordingly.
> 
> Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
>   include/linux/journal-head.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 75bc56109031..d68ae72784eb 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -80,13 +80,13 @@ struct journal_head {
>   	 * Pointer to the running compound transaction which is currently
>   	 * modifying the buffer's metadata, if there was already a transaction
>   	 * committing it when the new transaction touched it.
> -	 * [t_list_lock] [b_state_lock]
> +	 * [j_list_lock] [b_state_lock]
>   	 */
>   	transaction_t *b_next_transaction;
>   
>   	/*
>   	 * Doubly-linked list of buffers on a transaction's data, metadata or
> -	 * forget queue. [t_list_lock] [b_state_lock]
> +	 * forget queue. [j_list_lock] [b_state_lock]
>   	 */
>   	struct journal_head *b_tnext, *b_tprev;
>   
> 

-- 
Technische Universität Dortmund
Alexander Lochmann                PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16                 phone:  +49.231.7556141
D-44227 Dortmund                  fax:    +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]