* [PATCH] x86/mm: Fix copy&paste error in comments
@ 2021-04-20 5:34 Cao jin
2021-04-22 9:29 ` Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Cao jin @ 2021-04-20 5:34 UTC (permalink / raw)
To: x86, linux-kernel
Cc: tglx, mingo, bp, hpa, dave.hansen, luto, peterz, Cao jin
Direct page mapping in bottom-up way will allocate memory from low
address for page structures in a range, which is the *bottom*,
not the *end*.
Signed-off-by: Cao jin <jojing64@gmail.com>
---
arch/x86/mm/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index e26f5c5c6565..bc2f871c75f1 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -663,7 +663,7 @@ static void __init memory_map_bottom_up(unsigned long map_start,
/*
* We start from the bottom (@map_start) and go to the top (@map_end).
* The memblock_find_in_range() gets us a block of RAM from the
- * end of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
+ * bottom of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
* for page table.
*/
while (start < map_end) {
--
2.30.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/mm: Fix copy&paste error in comments
2021-04-20 5:34 [PATCH] x86/mm: Fix copy&paste error in comments Cao jin
@ 2021-04-22 9:29 ` Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ts'o @ 2021-04-22 9:29 UTC (permalink / raw)
To: x86, linux-kernel; +Cc: tglx, mingo, bp, hpa, dave.hansen, luto, peterz
On 20/4/2021 1:34 pm, Cao jin wrote:
> Direct page mapping in bottom-up way will allocate memory from low
> address for page structures in a range, which is the *bottom*,
> not the *end*.
>
> Signed-off-by: Cao jin <jojing64@gmail.com>
> ---
> arch/x86/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index e26f5c5c6565..bc2f871c75f1 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -663,7 +663,7 @@ static void __init memory_map_bottom_up(unsigned long map_start,
> /*
> * We start from the bottom (@map_start) and go to the top (@map_end).
> * The memblock_find_in_range() gets us a block of RAM from the
> - * end of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
> + * bottom of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
> * for page table.
> */
FYI: There is exactly the same sentence in memory_map_top_down(), looks
like a copy & paste error to me.
--
Cao jin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-22 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 5:34 [PATCH] x86/mm: Fix copy&paste error in comments Cao jin
2021-04-22 9:29 ` Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®