* [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page()
@ 2021-05-23 9:02 YueHaibing
2021-05-24 9:01 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2021-05-23 9:02 UTC (permalink / raw)
To: jack; +Cc: reiserfs-devel, linux-kernel, YueHaibing
Condition !A || A && B is equivalent to !A || B.
Generated by: scripts/coccinelle/misc/excluded_middle.cocci
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/reiserfs/inode.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index 780bb90c1804..f49b72ccac4c 100644
--- a/fs/reiserfs/inode.c
+++ b/fs/reiserfs/inode.c
@@ -2584,9 +2584,7 @@ static int reiserfs_write_full_page(struct page *page,
clear_buffer_dirty(bh);
set_buffer_uptodate(bh);
} else if ((checked || buffer_dirty(bh)) &&
- (!buffer_mapped(bh) || (buffer_mapped(bh)
- && bh->b_blocknr ==
- 0))) {
+ (!buffer_mapped(bh) || bh->b_blocknr == 0)) {
/*
* not mapped yet, or it points to a direct item, search
* the btree for the mapping info, and log any direct
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page()
2021-05-23 9:02 [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page() YueHaibing
@ 2021-05-24 9:01 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2021-05-24 9:01 UTC (permalink / raw)
To: YueHaibing; +Cc: jack, reiserfs-devel, linux-kernel
On Sun 23-05-21 17:02:58, YueHaibing wrote:
> Condition !A || A && B is equivalent to !A || B.
>
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Fair enough. Thanks for the patch. Added to my tree.
Honza
> ---
> fs/reiserfs/inode.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index 780bb90c1804..f49b72ccac4c 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -2584,9 +2584,7 @@ static int reiserfs_write_full_page(struct page *page,
> clear_buffer_dirty(bh);
> set_buffer_uptodate(bh);
> } else if ((checked || buffer_dirty(bh)) &&
> - (!buffer_mapped(bh) || (buffer_mapped(bh)
> - && bh->b_blocknr ==
> - 0))) {
> + (!buffer_mapped(bh) || bh->b_blocknr == 0)) {
> /*
> * not mapped yet, or it points to a direct item, search
> * the btree for the mapping info, and log any direct
> --
> 2.20.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-24 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23 9:02 [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page() YueHaibing
2021-05-24 9:01 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®