* Re: [PATCH] watchdog: da9063: Add hard dependency on I2C
@ 2021-11-29 15:32 Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-11-29 15:32 UTC (permalink / raw)
To: Andrej Picej; +Cc: wim, linux-watchdog, y.bas, linux-kernel
On Mon, Nov 29, 2021 at 02:49:38PM +0100, Andrej Picej wrote:
> Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
> reset handler") implements atomic save i2c transfer which uses i2c
> functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9d222ba17ec6..3207085f799f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -207,6 +207,7 @@ config DA9055_WATCHDOG
> config DA9063_WATCHDOG
> tristate "Dialog DA9063 Watchdog"
> depends on MFD_DA9063 || COMPILE_TEST
> + depends on I2C
> select WATCHDOG_CORE
> help
> Support for the watchdog in the DA9063 PMIC.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] watchdog: da9063: Add hard dependency on I2C
@ 2021-11-29 13:49 Andrej Picej
2021-11-29 15:13 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Andrej Picej @ 2021-11-29 13:49 UTC (permalink / raw)
To: wim, linux, linux-watchdog; +Cc: y.bas, linux-kernel
Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
reset handler") implements atomic save i2c transfer which uses i2c
functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 9d222ba17ec6..3207085f799f 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -207,6 +207,7 @@ config DA9055_WATCHDOG
config DA9063_WATCHDOG
tristate "Dialog DA9063 Watchdog"
depends on MFD_DA9063 || COMPILE_TEST
+ depends on I2C
select WATCHDOG_CORE
help
Support for the watchdog in the DA9063 PMIC.
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: da9063: Add hard dependency on I2C
2021-11-29 13:49 Andrej Picej
@ 2021-11-29 15:13 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-11-29 15:13 UTC (permalink / raw)
To: Andrej Picej, wim, linux-watchdog; +Cc: y.bas, linux-kernel
On 11/29/21 5:49 AM, Andrej Picej wrote:
> Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
> reset handler") implements atomic save i2c transfer which uses i2c
> functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9d222ba17ec6..3207085f799f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -207,6 +207,7 @@ config DA9055_WATCHDOG
> config DA9063_WATCHDOG
> tristate "Dialog DA9063 Watchdog"
> depends on MFD_DA9063 || COMPILE_TEST
> + depends on I2C
> select WATCHDOG_CORE
> help
> Support for the watchdog in the DA9063 PMIC.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-29 19:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 15:32 [PATCH] watchdog: da9063: Add hard dependency on I2C Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2021-11-29 13:49 Andrej Picej
2021-11-29 15:13 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®