[PATCH] can: gs_usb: Zero-initialize flags

[PATCH] can: gs_usb: Zero-initialize flags

[Brian Silverman]

No information is deliberately sent here in host->device communications,
but the open-source candleLight firmware echoes it back, which can
result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
spurious ERRORFRAMEs.

Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
---
 drivers/net/can/usb/gs_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 1b400de00f51..cc4ad8d59bd7 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,
 
 	hf->echo_id = idx;
 	hf->channel = dev->channel;
+	hf->flags = 0;
 
 	cf = (struct can_frame *)skb->data;
 

base-commit: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
-- 
2.20.1

Re: [PATCH] can: gs_usb: Zero-initialize flags

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On 05.01.2022 16:29:50, Brian Silverman wrote:
> No information is deliberately sent here in host->device communications,
> but the open-source candleLight firmware echoes it back, which can
> result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
> spurious ERRORFRAMEs.
> 
> Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>

Applied to linux-can/testing + opened an issue on github:
https://github.com/candle-usb/candleLight_fw/issues/87

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]