* [PATCH] tracing: check the return value of kstrndup()
@ 2021-12-14 2:26 xkernel.wang
2022-01-05 22:11 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: xkernel.wang @ 2021-12-14 2:26 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, Xiaoke Wang
From: Xiaoke Wang <xkernel.wang@foxmail.com>
kstrndup() is a memory allocation-related function, it returns NULL when
some internal memory errors happen. It is better to check the return
value of it so to catch the memory error in time.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
kernel/trace/trace_probe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 3ed2a3f..bb4605b 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -356,6 +356,8 @@ static int __parse_imm_string(char *str, char **pbuf, int offs)
return -EINVAL;
}
*pbuf = kstrndup(str, len - 1, GFP_KERNEL);
+ if (!*pbuf)
+ return -ENOMEM;
return 0;
}
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: check the return value of kstrndup()
2021-12-14 2:26 [PATCH] tracing: check the return value of kstrndup() xkernel.wang
@ 2022-01-05 22:11 ` Steven Rostedt
2022-01-05 22:40 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2022-01-05 22:11 UTC (permalink / raw)
To: xkernel.wang; +Cc: mingo, linux-kernel, Masami Hiramatsu
Masami, can you ack this?
-- Steve
On Tue, 14 Dec 2021 10:26:46 +0800
xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrndup() is a memory allocation-related function, it returns NULL when
> some internal memory errors happen. It is better to check the return
> value of it so to catch the memory error in time.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> kernel/trace/trace_probe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 3ed2a3f..bb4605b 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -356,6 +356,8 @@ static int __parse_imm_string(char *str, char **pbuf, int offs)
> return -EINVAL;
> }
> *pbuf = kstrndup(str, len - 1, GFP_KERNEL);
> + if (!*pbuf)
> + return -ENOMEM;
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: check the return value of kstrndup()
2022-01-05 22:11 ` Steven Rostedt
@ 2022-01-05 22:40 ` Masami Hiramatsu
0 siblings, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2022-01-05 22:40 UTC (permalink / raw)
To: Steven Rostedt; +Cc: xkernel.wang, mingo, linux-kernel, Masami Hiramatsu
On Wed, 5 Jan 2022 17:11:12 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> Masami, can you ack this?
Yes, thanks for fowarding.
>
> -- Steve
>
>
> On Tue, 14 Dec 2021 10:26:46 +0800
> xkernel.wang@foxmail.com wrote:
>
> > From: Xiaoke Wang <xkernel.wang@foxmail.com>
> >
> > kstrndup() is a memory allocation-related function, it returns NULL when
> > some internal memory errors happen. It is better to check the return
> > value of it so to catch the memory error in time.
Thanks for fixing!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Fixes: a42e3c4de964 ("tracing/probe: Add immediate string parameter support")
> >
> > Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> > ---
> > kernel/trace/trace_probe.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> > index 3ed2a3f..bb4605b 100644
> > --- a/kernel/trace/trace_probe.c
> > +++ b/kernel/trace/trace_probe.c
> > @@ -356,6 +356,8 @@ static int __parse_imm_string(char *str, char **pbuf, int offs)
> > return -EINVAL;
> > }
> > *pbuf = kstrndup(str, len - 1, GFP_KERNEL);
> > + if (!*pbuf)
> > + return -ENOMEM;
> > return 0;
> > }
> >
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-05 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 2:26 [PATCH] tracing: check the return value of kstrndup() xkernel.wang
2022-01-05 22:11 ` Steven Rostedt
2022-01-05 22:40 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome