* [PATCH] srcu: make srcu_size_state_name static
@ 2022-01-29 3:45 Jiapeng Chong
2022-02-01 19:23 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-01-29 3:45 UTC (permalink / raw)
To: jiangshanlai
Cc: paulmck, josh, rostedt, mathieu.desnoyers, rcu, linux-kernel,
Jiapeng Chong, Abaci Robot
This symbol is not used outside of srcutree.c, so marks it static.
Fixes the following sparse warning:
kernel/rcu/srcutree.c:1426:12: warning: symbol 'srcu_size_state_name'
was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/rcu/srcutree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
index 4201815744d8..31dbd41332f6 100644
--- a/kernel/rcu/srcutree.c
+++ b/kernel/rcu/srcutree.c
@@ -1423,7 +1423,7 @@ void srcutorture_get_gp_data(enum rcutorture_type test_type,
}
EXPORT_SYMBOL_GPL(srcutorture_get_gp_data);
-const char * const srcu_size_state_name[] =
+static const char * const srcu_size_state_name[] =
{
"SRCU_SIZE_SMALL",
"SRCU_SIZE_ALLOC",
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] srcu: make srcu_size_state_name static
2022-01-29 3:45 [PATCH] srcu: make srcu_size_state_name static Jiapeng Chong
@ 2022-02-01 19:23 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2022-02-01 19:23 UTC (permalink / raw)
To: Jiapeng Chong
Cc: jiangshanlai, josh, rostedt, mathieu.desnoyers, rcu,
linux-kernel, Abaci Robot
On Sat, Jan 29, 2022 at 11:45:02AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of srcutree.c, so marks it static.
>
> Fixes the following sparse warning:
>
> kernel/rcu/srcutree.c:1426:12: warning: symbol 'srcu_size_state_name'
> was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
And I did queue and push this, good catch, thank you!
Thanx, Paul
> ---
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 4201815744d8..31dbd41332f6 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -1423,7 +1423,7 @@ void srcutorture_get_gp_data(enum rcutorture_type test_type,
> }
> EXPORT_SYMBOL_GPL(srcutorture_get_gp_data);
>
> -const char * const srcu_size_state_name[] =
> +static const char * const srcu_size_state_name[] =
> {
> "SRCU_SIZE_SMALL",
> "SRCU_SIZE_ALLOC",
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-01 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 3:45 [PATCH] srcu: make srcu_size_state_name static Jiapeng Chong
2022-02-01 19:23 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®