From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: <p.yadav@ti.com>, <michael@walle.cc>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<nicolas.ferre@microchip.com>, <zhengxunli@mxic.com.tw>,
<jaimeliao@mxic.com.tw>,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: [PATCH v6 3/7] mtd: spi-nor: core: Use auto-detection only once
Date: Wed, 9 Feb 2022 15:36:52 +0200 [thread overview]
Message-ID: <20220209133656.374903-4-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20220209133656.374903-1-tudor.ambarus@microchip.com>
In case spi_nor_match_name() returned NULL, the auto detection was
issued twice. There's no reason to try to detect the same chip twice,
do the auto detection only once.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
drivers/mtd/spi-nor/core.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 335170fc2438..9b740f77174e 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -3127,13 +3127,15 @@ static const struct flash_info *spi_nor_match_name(struct spi_nor *nor,
static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor,
const char *name)
{
- const struct flash_info *info = NULL;
+ const struct flash_info *info = NULL, *detected_info = NULL;
if (name)
info = spi_nor_match_name(nor, name);
/* Try to auto-detect if chip name wasn't specified or not found */
- if (!info)
- info = spi_nor_read_id(nor);
+ if (!info) {
+ detected_info = spi_nor_read_id(nor);
+ info = detected_info;
+ }
if (IS_ERR_OR_NULL(info))
return ERR_PTR(-ENOENT);
@@ -3141,7 +3143,7 @@ static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor,
* If caller has specified name of flash model that can normally be
* detected using JEDEC, let's verify it.
*/
- if (name && info->id_len) {
+ if (name && !detected_info && info->id_len) {
const struct flash_info *jinfo;
jinfo = spi_nor_read_id(nor);
--
2.25.1
next prev parent reply other threads:[~2022-02-09 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 13:36 [PATCH v6 0/7] mtd: spi-nor: Prepare core and add support for mx66lm1g45g Tudor Ambarus
2022-02-09 13:36 ` [PATCH v6 1/7] mtd: spi-nor: Rename method, s/spi_nor_match_id/spi_nor_match_name Tudor Ambarus
2022-03-21 11:53 ` Pratyush Yadav
2022-03-21 11:55 ` Pratyush Yadav
2022-02-09 13:36 ` [PATCH v6 2/7] mtd: spi-nor: Introduce spi_nor_match_id() Tudor Ambarus
2022-02-09 13:36 ` Tudor Ambarus [this message]
2022-02-09 13:36 ` [PATCH v6 4/7] mtd: spi-nor: core: Introduce method for RDID op Tudor Ambarus
2022-02-09 13:36 ` [PATCH v6 5/7] mtd: spi-nor: manufacturers: Use spi_nor_read_id() core method Tudor Ambarus
2022-02-09 13:36 ` [PATCH v6 6/7] mtd: spi-nor: core: Introduce SPI_NOR_SOFT_RESET flash_info fixup_flag Tudor Ambarus
2022-02-09 13:36 ` [PATCH v6 7/7] mtd: spi-nor: macronix: Add support for mx66lm1g45g Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209133656.374903-4-tudor.ambarus@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=jaimeliao@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®