* [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print function dev_err()
@ 2022-02-24 1:23 Yang Li
2022-05-04 7:49 ` CK Hu
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-02-24 1:23 UTC (permalink / raw)
To: matthias.bgg
Cc: airlied, daniel, p.zabel, chunkuang.hu, dri-devel,
linux-mediatek, linux-arm-kernel, linux-kernel, Yang Li,
Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/gpu/drm/mediatek/mtk_dsi.c:1092:2-9: line 1092 is redundant
because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index bced4c7d668e..704252ee1198 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1089,7 +1089,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
irq_num = platform_get_irq(pdev, 0);
if (irq_num < 0) {
- dev_err(&pdev->dev, "failed to get dsi irq_num: %d\n", irq_num);
ret = irq_num;
goto err_unregister_host;
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print function dev_err()
2022-02-24 1:23 [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print function dev_err() Yang Li
@ 2022-05-04 7:49 ` CK Hu
0 siblings, 0 replies; 2+ messages in thread
From: CK Hu @ 2022-05-04 7:49 UTC (permalink / raw)
To: Yang Li, matthias.bgg
Cc: chunkuang.hu, airlied, Abaci Robot, linux-kernel, dri-devel,
linux-mediatek, linux-arm-kernel
Hi, Yang:
On Thu, 2022-02-24 at 09:23 +0800, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/mediatek/mtk_dsi.c:1092:2-9: line 1092 is redundant
> because platform_get_irq() already prints an error
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index bced4c7d668e..704252ee1198 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1089,7 +1089,6 @@ static int mtk_dsi_probe(struct platform_device
> *pdev)
>
> irq_num = platform_get_irq(pdev, 0);
> if (irq_num < 0) {
> - dev_err(&pdev->dev, "failed to get dsi irq_num: %d\n",
> irq_num);
> ret = irq_num;
> goto err_unregister_host;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-04 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 1:23 [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print function dev_err() Yang Li
2022-05-04 7:49 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®