* [PATCH 0/1] mt8192: Add mmc device nodes @ 2022-04-01 5:30 Allen-KH Cheng 2022-04-01 5:30 ` [PATCH 1/1] arm64: dts: " Allen-KH Cheng 0 siblings, 1 reply; 3+ messages in thread From: Allen-KH Cheng @ 2022-04-01 5:30 UTC (permalink / raw) To: Matthias Brugger, Rob Herring Cc: Project_Global_Chrome_Upstream_Group, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, Chen-Yu Tsai, Ryder Lee, Hui Liu, Allen-KH Cheng Take mmc device patch from series 20220330133816.30806-1-allen-kh.cheng@mediatek.com/ This series are based on matthias.bgg/linux.git, v5.18-next/dts64 Changes history of mmc: changes since v5:$ - mmc: diable the msdc clock node, drop reviewed-by tags. changes since v4: - mmc: reserve msdc node changes since v3: - mmc: reorder clocks as specified in the dt-bindings changes since v2: - mmc: use single line for reg changes since v1: - none Allen-KH Cheng (1): arm64: dts: mt8192: Add mmc device nodes arch/arm64/boot/dts/mediatek/mt8192.dtsi | 33 ++++++++++++++++++++++++ 1 file changed, 33 insertions(+) -- 2.18.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] arm64: dts: mt8192: Add mmc device nodes 2022-04-01 5:30 [PATCH 0/1] mt8192: Add mmc device nodes Allen-KH Cheng @ 2022-04-01 5:30 ` Allen-KH Cheng 2022-04-04 12:36 ` AngeloGioacchino Del Regno 0 siblings, 1 reply; 3+ messages in thread From: Allen-KH Cheng @ 2022-04-01 5:30 UTC (permalink / raw) To: Matthias Brugger, Rob Herring Cc: Project_Global_Chrome_Upstream_Group, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, Chen-Yu Tsai, Ryder Lee, Hui Liu, Allen-KH Cheng Add mmc nodes for mt8192 SoC. Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 33 ++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index a6da7b04b9d4..23eb92057cb9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi @@ -989,6 +989,39 @@ compatible = "mediatek,mt8192-msdc"; reg = <0 0x11f60000 0 0x1000>; #clock-cells = <1>; + status = "disabled"; + }; + + mmc0: mmc@11f60000 { + compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; + reg = <0 0x11f60000 0 0x1000>, <0 0x11f50000 0 0x1000>; + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>, + <&msdc_top CLK_MSDC_TOP_H_MST_0P>, + <&msdc_top CLK_MSDC_TOP_SRC_0P>, + <&msdc_top CLK_MSDC_TOP_P_CFG>, + <&msdc_top CLK_MSDC_TOP_P_MSDC0>, + <&msdc_top CLK_MSDC_TOP_AXI>, + <&msdc_top CLK_MSDC_TOP_AHB2AXI_BRG_AXI>; + clock-names = "source", "hclk", "source_cg", "sys_cg", + "pclk_cg", "axi_cg", "ahb_cg"; + status = "disabled"; + }; + + mmc1: mmc@11f70000 { + compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; + reg = <0 0x11f70000 0 0x1000>, <0 0x11c70000 0 0x1000>; + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&topckgen CLK_TOP_MSDC30_1_SEL>, + <&msdc_top CLK_MSDC_TOP_H_MST_1P>, + <&msdc_top CLK_MSDC_TOP_SRC_1P>, + <&msdc_top CLK_MSDC_TOP_P_CFG>, + <&msdc_top CLK_MSDC_TOP_P_MSDC1>, + <&msdc_top CLK_MSDC_TOP_AXI>, + <&msdc_top CLK_MSDC_TOP_AHB2AXI_BRG_AXI>; + clock-names = "source", "hclk", "source_cg", "sys_cg", + "pclk_cg", "axi_cg", "ahb_cg"; + status = "disabled"; }; mfgcfg: clock-controller@13fbf000 { -- 2.18.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] arm64: dts: mt8192: Add mmc device nodes 2022-04-01 5:30 ` [PATCH 1/1] arm64: dts: " Allen-KH Cheng @ 2022-04-04 12:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 3+ messages in thread From: AngeloGioacchino Del Regno @ 2022-04-04 12:36 UTC (permalink / raw) To: Allen-KH Cheng, Matthias Brugger, Rob Herring Cc: Project_Global_Chrome_Upstream_Group, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, Chen-Yu Tsai, Ryder Lee, Hui Liu Il 01/04/22 07:30, Allen-KH Cheng ha scritto: > Add mmc nodes for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 33 ++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index a6da7b04b9d4..23eb92057cb9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -989,6 +989,39 @@ > compatible = "mediatek,mt8192-msdc"; > reg = <0 0x11f60000 0 0x1000>; > #clock-cells = <1>; > + status = "disabled"; > + }; > + Hello! Please explain the reason (in the commit message) why you're disabling the mediatek,mt8192-msdc node, which was enabled before this change. Also, introducing the mtk-sd controller at the same address as the mt8192-msdc clock controller will produce a warning... Thanks, Angelo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-04 12:37 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-04-01 5:30 [PATCH 0/1] mt8192: Add mmc device nodes Allen-KH Cheng 2022-04-01 5:30 ` [PATCH 1/1] arm64: dts: " Allen-KH Cheng 2022-04-04 12:36 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®