[PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments

[PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments

[Jiang Jian]

there is an unexpected word 'and' in the comments that need to be dropped

file: arch/alpha/kernel/irq_i8259.c
line: 150

*  Therefore, read the mask register and and out those lines

changed to:

*  Therefore, read the mask register and and out those lines

Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
---
 arch/alpha/kernel/irq_i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/irq_i8259.c b/arch/alpha/kernel/irq_i8259.c
index 1dcf0d9038fd..db574dcd6675 100644
--- a/arch/alpha/kernel/irq_i8259.c
+++ b/arch/alpha/kernel/irq_i8259.c
@@ -147,7 +147,7 @@ isa_no_iack_sc_device_interrupt(unsigned long vector)
 	 */
 	/* 
 	 *  The first read of gives you *all* interrupting lines.
-	 *  Therefore, read the mask register and and out those lines
+	 *  Therefore, read the mask register and out those lines
 	 *  not enabled.  Note that some documentation has 21 and a1 
 	 *  write only.  This is not true.
 	 */
-- 
2.17.1

Re: [PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments

[Conor.Dooley]

On 22/06/2022 15:02, Jiang Jian wrote:
> there is an unexpected word 'and' in the comments that need to be dropped
> 
> file: arch/alpha/kernel/irq_i8259.c
> line: 150
> 
> *  Therefore, read the mask register and and out those lines
> 
> changed to:
> 
> *  Therefore, read the mask register and and out those lines
> 
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
>   arch/alpha/kernel/irq_i8259.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/alpha/kernel/irq_i8259.c b/arch/alpha/kernel/irq_i8259.c
> index 1dcf0d9038fd..db574dcd6675 100644
> --- a/arch/alpha/kernel/irq_i8259.c
> +++ b/arch/alpha/kernel/irq_i8259.c
> @@ -147,7 +147,7 @@ isa_no_iack_sc_device_interrupt(unsigned long vector)
>   	 */
>   	/*
>   	 *  The first read of gives you *all* interrupting lines.
> -	 *  Therefore, read the mask register and and out those lines
> +	 *  Therefore, read the mask register and out those lines

This does not look like a typo? Surely the second and means the
operator? Maybe it could be reworded for more clarity to something
like "and mask out", but the initial meaning looks sane

Thanks,
Conor.

>   	 *  not enabled.  Note that some documentation has 21 and a1
>   	 *  write only.  This is not true.
>   	 */

Re: 回复：[PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments

[Conor.Dooley]

On 22/06/2022 15:13, 蒋健 wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> I misunderstood it, thank you for your guidance.

Please don't send HTML mails to the list, if you do only (some) direct
recipients will get the mail.
Thanks,
Conor.

> ------------------ 原始邮件 ------------------
> *发件人:* "Conor.Dooley";
> *发送时间:* 2022年6月22日(星期三) 晚上10:08
> *收件人:* "jiangjian"; "rth"; "ink"; "mattst88";
> *抄送:* "linux-alpha"; "linux-kernel";
> *主题:* Re: [PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments
> 
> On 22/06/2022 15:02, Jiang Jian wrote:
>  > there is an unexpected word 'and' in the comments that need to be dropped
>  >
>  > file: arch/alpha/kernel/irq_i8259.c
>  > line: 150
>  >
>  > *  Therefore, read the mask register and and out those lines
>  >
>  > changed to:
>  >
>  > *  Therefore, read the mask register and and out those lines
>  >
>  > Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
>  > ---
>  >   arch/alpha/kernel/irq_i8259.c | 2 +-
>  >   1 file changed, 1 insertion(+), 1 deletion(-)
>  >
>  > diff --git a/arch/alpha/kernel/irq_i8259.c b/arch/alpha/kernel/irq_i8259.c
>  > index 1dcf0d9038fd..db574dcd6675 100644
>  > --- a/arch/alpha/kernel/irq_i8259.c
>  > +++ b/arch/alpha/kernel/irq_i8259.c
>  > @@ -147,7 +147,7 @@ isa_no_iack_sc_device_interrupt(unsigned long vector)
>  >     */
>  >    /*
>  >     *  The first read of gives you *all* interrupting lines.
>  > -  *  Therefore, read the mask register and and out those lines
>  > +  *  Therefore, read the mask register and out those lines
> 
> This does not look like a typo? Surely the second and means the
> operator? Maybe it could be reworded for more clarity to something
> like "and mask out", but the initial meaning looks sane
> 
> Thanks,
> Conor.
> 
>  >     *  not enabled.  Note that some documentation has 21 and a1
>  >     *  write only.  This is not true.
>  >     */