* [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static
@ 2022-06-26 14:46 Tom Rix
2022-06-27 13:20 ` Aurabindo Pillai
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2022-06-26 14:46 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, Qingqing.Zhuo,
mario.limonciello, nicholas.kazlauskas, aurabindo.pillai,
maira.canal
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its
storage class specifier to static.
Fixes: 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
index 3a213ca2f077..b1012fa1977b 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
@@ -36,7 +36,7 @@
#define DCN_BASE__INST0_SEG2 0x000034C0
-enum dc_irq_source to_dal_irq_source_dcn32(
+static enum dc_irq_source to_dal_irq_source_dcn32(
struct irq_service *irq_service,
uint32_t src_id,
uint32_t ext_id)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static
2022-06-26 14:46 [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static Tom Rix
@ 2022-06-27 13:20 ` Aurabindo Pillai
2022-06-27 21:43 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Aurabindo Pillai @ 2022-06-27 13:20 UTC (permalink / raw)
To: Tom Rix, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
Qingqing.Zhuo, mario.limonciello, nicholas.kazlauskas,
maira.canal
Cc: amd-gfx, dri-devel, linux-kernel
On 2022-06-26 10:46, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
>
> to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its
> storage class specifier to static.
>
> Fixes: 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> index 3a213ca2f077..b1012fa1977b 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> @@ -36,7 +36,7 @@
>
> #define DCN_BASE__INST0_SEG2 0x000034C0
>
> -enum dc_irq_source to_dal_irq_source_dcn32(
> +static enum dc_irq_source to_dal_irq_source_dcn32(
> struct irq_service *irq_service,
> uint32_t src_id,
> uint32_t ext_id)
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static
2022-06-27 13:20 ` Aurabindo Pillai
@ 2022-06-27 21:43 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2022-06-27 21:43 UTC (permalink / raw)
To: Aurabindo Pillai
Cc: Tom Rix, Wentland, Harry, Leo (Sunpeng) Li, Siqueira, Rodrigo,
Deucher, Alexander, Christian Koenig, xinhui pan, Dave Airlie,
Daniel Vetter, Qingqing Zhuo, Limonciello, Mario, Kazlauskas,
Nicholas, Maíra Canal, Maling list - DRI developers,
amd-gfx list, LKML
Applied. Thanks!
Alex
On Mon, Jun 27, 2022 at 9:20 AM Aurabindo Pillai
<aurabindo.pillai@amd.com> wrote:
>
>
>
> On 2022-06-26 10:46, Tom Rix wrote:
> > sparse reports
> > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
> >
> > to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its
> > storage class specifier to static.
> >
> > Fixes: 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> > drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> > index 3a213ca2f077..b1012fa1977b 100644
> > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> > @@ -36,7 +36,7 @@
> >
> > #define DCN_BASE__INST0_SEG2 0x000034C0
> >
> > -enum dc_irq_source to_dal_irq_source_dcn32(
> > +static enum dc_irq_source to_dal_irq_source_dcn32(
> > struct irq_service *irq_service,
> > uint32_t src_id,
> > uint32_t ext_id)
>
> Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-27 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-26 14:46 [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static Tom Rix
2022-06-27 13:20 ` Aurabindo Pillai
2022-06-27 21:43 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®