* [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset
@ 2022-07-06 18:29 T.J. Mercier
2022-07-06 18:31 ` T.J. Mercier
2022-08-19 16:32 ` Lucas Stach
0 siblings, 2 replies; 3+ messages in thread
From: T.J. Mercier @ 2022-07-06 18:29 UTC (permalink / raw)
To: tjmercier, Lucas Stach, Russell King, Christian Gmeiner,
David Airlie, Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
The docs explicitly say the drm_gem_object_release function already calls this,
and this does not appear to be a prerequisite for the call to
etnaviv_gem_ops.release.
Signed-off-by: T.J. Mercier <tjmercier@google.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index cc386f8a7116..ecb828e4e156 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -504,7 +504,6 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj)
kfree(mapping);
}
- drm_gem_free_mmap_offset(obj);
etnaviv_obj->ops->release(etnaviv_obj);
drm_gem_object_release(obj);
--
2.37.0.rc0.161.g10f37bed90-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset
2022-07-06 18:29 [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset T.J. Mercier
@ 2022-07-06 18:31 ` T.J. Mercier
2022-08-19 16:32 ` Lucas Stach
1 sibling, 0 replies; 3+ messages in thread
From: T.J. Mercier @ 2022-07-06 18:31 UTC (permalink / raw)
To: T.J. Mercier, Lucas Stach, Russell King, Christian Gmeiner,
David Airlie, Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
On Wed, Jul 6, 2022 at 11:29 AM T.J. Mercier <tjmercier@google.com> wrote:
>
> The docs explicitly say the drm_gem_object_release function already calls this,
> and this does not appear to be a prerequisite for the call to
> etnaviv_gem_ops.release.
>
> Signed-off-by: T.J. Mercier <tjmercier@google.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index cc386f8a7116..ecb828e4e156 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -504,7 +504,6 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj)
> kfree(mapping);
> }
>
> - drm_gem_free_mmap_offset(obj);
> etnaviv_obj->ops->release(etnaviv_obj);
> drm_gem_object_release(obj);
>
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>
I don't have a device to test this with, but I believe this is correct
based on inspecting the code and the drm_gem_free_mmap_offset function
docs.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset
2022-07-06 18:29 [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset T.J. Mercier
2022-07-06 18:31 ` T.J. Mercier
@ 2022-08-19 16:32 ` Lucas Stach
1 sibling, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2022-08-19 16:32 UTC (permalink / raw)
To: T.J. Mercier, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
Am Mittwoch, dem 06.07.2022 um 18:29 +0000 schrieb T.J. Mercier:
> The docs explicitly say the drm_gem_object_release function already calls this,
> and this does not appear to be a prerequisite for the call to
> etnaviv_gem_ops.release.
>
This looks correct to me. Patch applied to etnaviv/next.
Regards,
Lucas
> Signed-off-by: T.J. Mercier <tjmercier@google.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index cc386f8a7116..ecb828e4e156 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -504,7 +504,6 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj)
> kfree(mapping);
> }
>
> - drm_gem_free_mmap_offset(obj);
> etnaviv_obj->ops->release(etnaviv_obj);
> drm_gem_object_release(obj);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-19 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 18:29 [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset T.J. Mercier
2022-07-06 18:31 ` T.J. Mercier
2022-08-19 16:32 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®