mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] net: ethernet/sfc: Fix comment typo
@ 2022-07-15  4:59 Jason Wang
  2022-07-18 14:19 ` Edward Cree
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2022-07-15  4:59 UTC (permalink / raw)
  To: edumazet
  Cc: ecree.xilinx, habetsm.xilinx, davem, kuba, pabeni, netdev,
	linux-kernel, Jason Wang

The double `that' is duplicated in line 2438, remove one.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/net/ethernet/sfc/falcon/falcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/falcon/falcon.c b/drivers/net/ethernet/sfc/falcon/falcon.c
index 3324a6219a09..9fcd28500939 100644
--- a/drivers/net/ethernet/sfc/falcon/falcon.c
+++ b/drivers/net/ethernet/sfc/falcon/falcon.c
@@ -2435,7 +2435,7 @@ static void falcon_init_rx_cfg(struct ef4_nic *efx)
 		 * supports scattering for user-mode queues, but will
 		 * split DMA writes at intervals of RX_USR_BUF_SIZE
 		 * (32-byte units) even for kernel-mode queues.  We
-		 * set it to be so large that that never happens.
+		 * set it to be so large that never happens.
 		 */
 		EF4_SET_OWORD_FIELD(reg, FRF_AA_RX_DESC_PUSH_EN, 0);
 		EF4_SET_OWORD_FIELD(reg, FRF_AA_RX_USR_BUF_SIZE,
-- 
2.35.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ethernet/sfc: Fix comment typo
  2022-07-15  4:59 [PATCH] net: ethernet/sfc: Fix comment typo Jason Wang
@ 2022-07-18 14:19 ` Edward Cree
  0 siblings, 0 replies; 2+ messages in thread
From: Edward Cree @ 2022-07-18 14:19 UTC (permalink / raw)
  To: Jason Wang, edumazet
  Cc: habetsm.xilinx, davem, kuba, pabeni, netdev, linux-kernel

On 15/07/2022 05:59, Jason Wang wrote:
> The double `that' is duplicated in line 2438, remove one.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/net/ethernet/sfc/falcon/falcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/falcon/falcon.c b/drivers/net/ethernet/sfc/falcon/falcon.c
> index 3324a6219a09..9fcd28500939 100644
> --- a/drivers/net/ethernet/sfc/falcon/falcon.c
> +++ b/drivers/net/ethernet/sfc/falcon/falcon.c
> @@ -2435,7 +2435,7 @@ static void falcon_init_rx_cfg(struct ef4_nic *efx)
>  		 * supports scattering for user-mode queues, but will
>  		 * split DMA writes at intervals of RX_USR_BUF_SIZE
>  		 * (32-byte units) even for kernel-mode queues.  We
> -		 * set it to be so large that that never happens.
> +		 * set it to be so large that never happens.
>  		 */
>  		EF4_SET_OWORD_FIELD(reg, FRF_AA_RX_DESC_PUSH_EN, 0);
>  		EF4_SET_OWORD_FIELD(reg, FRF_AA_RX_USR_BUF_SIZE,
> 

Nack.  The first 'that' is a subordinating conjunction, the second is
 a demonstrative pronoun, so this is not a mere duplication.
(Admittedly, some writers would omit the conjunction, but I think the
 sentence reads more clearly with it present.)
One possible alternative would be to change the second 'that' to
 'this' or 'the above', or even 'such splitting', if you really find
 the original confusing.

-ed

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-18 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15  4:59 [PATCH] net: ethernet/sfc: Fix comment typo Jason Wang
2022-07-18 14:19 ` Edward Cree

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®