mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x
@ 2022-07-20 11:21 Lukas Bulwahn
  2022-07-20 18:36 ` Péter Ujfalusi
  2022-07-26  7:43 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2022-07-20 11:21 UTC (permalink / raw)
  To: Peter Ujfalusi, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel
  Cc: Linus Walleij, kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 7dd33764486d ("ARM: davinci: Delete DM644x board files") and commit
b4aed01de486 ("ARM: davinci: Delete DM646x board files") removes the
support for DaVinci DM644x and DM646x boards.

Hence, remove the sound support for those boards as well.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 sound/soc/ti/Kconfig | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
index 40110e9a9e8a..35fddd7c501a 100644
--- a/sound/soc/ti/Kconfig
+++ b/sound/soc/ti/Kconfig
@@ -180,9 +180,6 @@ config SND_SOC_DAVINCI_EVM
 	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_DM355_EVM
 	select SND_SOC_DAVINCI_ASP if SND_SOC_DM365_AIC3X_CODEC
 	select SND_SOC_DAVINCI_VCIF if SND_SOC_DM365_VOICE_CODEC
-	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_EVM # DM6446
-	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DM6467_EVM
-	select SND_SOC_SPDIF if MACH_DAVINCI_DM6467_EVM
 	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA830_EVM
 	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA850_EVM
 	select SND_SOC_TLV320AIC3X
@@ -191,8 +188,6 @@ config SND_SOC_DAVINCI_EVM
 	  DaVinci EVM platforms:
 	  - DM355
 	  - DM365
-	  - DM6446
-	  - DM6447
 	  - DM830
 	  - DM850
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x
  2022-07-20 11:21 [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x Lukas Bulwahn
@ 2022-07-20 18:36 ` Péter Ujfalusi
  2022-07-26  7:43 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2022-07-20 18:36 UTC (permalink / raw)
  To: Lukas Bulwahn, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel
  Cc: Linus Walleij, kernel-janitors, linux-kernel

Hi Lukas,

On 20/07/2022 14:21, Lukas Bulwahn wrote:
> Commit 7dd33764486d ("ARM: davinci: Delete DM644x board files") and commit
> b4aed01de486 ("ARM: davinci: Delete DM646x board files") removes the
> support for DaVinci DM644x and DM646x boards.
> 
> Hence, remove the sound support for those boards as well.

This is not going to remove the sound support, it is just removes the
select, which is now rendered NOP as neither MACH_DAVINCI_EVM nor
MACH_DAVINCI_DM6467_EVM is an option to select...

There is still structs and some code in davinci-evm.c in the path of
if (machine_is_davinci_evm())
and
else if (machine_is_davinci_dm6467_evm())

Those can also go, but I can only  drop that in about two weeks from now...

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  sound/soc/ti/Kconfig | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
> index 40110e9a9e8a..35fddd7c501a 100644
> --- a/sound/soc/ti/Kconfig
> +++ b/sound/soc/ti/Kconfig
> @@ -180,9 +180,6 @@ config SND_SOC_DAVINCI_EVM
>  	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_DM355_EVM
>  	select SND_SOC_DAVINCI_ASP if SND_SOC_DM365_AIC3X_CODEC
>  	select SND_SOC_DAVINCI_VCIF if SND_SOC_DM365_VOICE_CODEC
> -	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_EVM # DM6446
> -	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DM6467_EVM
> -	select SND_SOC_SPDIF if MACH_DAVINCI_DM6467_EVM
>  	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA830_EVM
>  	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA850_EVM
>  	select SND_SOC_TLV320AIC3X
> @@ -191,8 +188,6 @@ config SND_SOC_DAVINCI_EVM
>  	  DaVinci EVM platforms:
>  	  - DM355
>  	  - DM365
> -	  - DM6446
> -	  - DM6447
>  	  - DM830
>  	  - DM850
>  

-- 
Péter

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x
  2022-07-20 11:21 [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x Lukas Bulwahn
  2022-07-20 18:36 ` Péter Ujfalusi
@ 2022-07-26  7:43 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-07-26  7:43 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Peter Ujfalusi, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, kernel-janitors, linux-kernel

On Wed, Jul 20, 2022 at 1:22 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> Commit 7dd33764486d ("ARM: davinci: Delete DM644x board files") and commit
> b4aed01de486 ("ARM: davinci: Delete DM646x board files") removes the
> support for DaVinci DM644x and DM646x boards.
>
> Hence, remove the sound support for those boards as well.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-26  7:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 11:21 [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x Lukas Bulwahn
2022-07-20 18:36 ` Péter Ujfalusi
2022-07-26  7:43 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®