* [PATCH linux-next] IB/cm:Change the conditional statements
@ 2022-08-01 2:31 cgel.zte
2022-08-01 2:41 ` Mark Zhang
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-01 2:31 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-rdma, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Conditional statements could changed to be easier explain.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/infiniband/core/cm.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index b985e0d9bc05..6e323d0c0fce 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -676,14 +676,9 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
refcount_inc(&cm_id_priv->refcount);
return cm_id_priv;
}
- if (device < cm_id_priv->id.device)
+ if (device < cm_id_priv->id.device ||
+ be64_lt(service_id, cm_id_priv->id.service_id))
node = node->rb_left;
- else if (device > cm_id_priv->id.device)
- node = node->rb_right;
- else if (be64_lt(service_id, cm_id_priv->id.service_id))
- node = node->rb_left;
- else if (be64_gt(service_id, cm_id_priv->id.service_id))
- node = node->rb_right;
else
node = node->rb_right;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] IB/cm:Change the conditional statements
2022-08-01 2:31 [PATCH linux-next] IB/cm:Change the conditional statements cgel.zte
@ 2022-08-01 2:41 ` Mark Zhang
0 siblings, 0 replies; 2+ messages in thread
From: Mark Zhang @ 2022-08-01 2:41 UTC (permalink / raw)
To: cgel.zte, linux-kernel; +Cc: linux-rdma, ye xingchen, Zeal Robot
On 8/1/2022 10:31 AM, cgel.zte@gmail.com wrote:
> External email: Use caution opening links or attachments
>
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Conditional statements could changed to be easier explain.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/infiniband/core/cm.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index b985e0d9bc05..6e323d0c0fce 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -676,14 +676,9 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
> refcount_inc(&cm_id_priv->refcount);
> return cm_id_priv;
> }
> - if (device < cm_id_priv->id.device)
> + if (device < cm_id_priv->id.device ||
> + be64_lt(service_id, cm_id_priv->id.service_id))
> node = node->rb_left;
> - else if (device > cm_id_priv->id.device)
> - node = node->rb_right;
> - else if (be64_lt(service_id, cm_id_priv->id.service_id))
> - node = node->rb_left;
> - else if (be64_gt(service_id, cm_id_priv->id.service_id))
> - node = node->rb_right;
> else
> node = node->rb_right;
> }
> --
> 2.25.1
This is not correct, ref.:
https://lore.kernel.org/lkml/20220624201733.GA284068@nvidia.com/t/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-01 2:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 2:31 [PATCH linux-next] IB/cm:Change the conditional statements cgel.zte
2022-08-01 2:41 ` Mark Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®