From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jbaron@akamai.com
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 09/11] dyndbg: drop EXPORTed dynamic_debug_exec_queries
Date: Thu, 11 Aug 2022 11:35:39 -0600 [thread overview]
Message-ID: <20220811173541.2901122-10-jim.cromie@gmail.com> (raw)
In-Reply-To: <20220811173541.2901122-1-jim.cromie@gmail.com>
This exported fn is unused, and will not be needed. Lets dump it.
The export was added to let drm control pr_debugs, as part of using
them to avoid drm_debug_enabled overheads. But its better to just
implement the drm.debug bitmap interface, then its available for
everyone.
Fixes: a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()")
Fixes: 4c0d77828d4f ("dyndbg: export ddebug_exec_queries")
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Acked-by: Jason Baron <jbaron@akamai.com>
---
include/linux/dynamic_debug.h | 9 ---------
lib/dynamic_debug.c | 29 -----------------------------
2 files changed, 38 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index f30b01aa9fa4..8d9eec5f6d8b 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -55,9 +55,6 @@ struct _ddebug {
#if defined(CONFIG_DYNAMIC_DEBUG_CORE)
-/* exported for module authors to exercise >control */
-int dynamic_debug_exec_queries(const char *query, const char *modname);
-
int ddebug_add_module(struct _ddebug *tab, unsigned int n,
const char *modname);
extern int ddebug_remove_module(const char *mod_name);
@@ -221,12 +218,6 @@ static inline int ddebug_dyndbg_module_param_cb(char *param, char *val,
rowsize, groupsize, buf, len, ascii); \
} while (0)
-static inline int dynamic_debug_exec_queries(const char *query, const char *modname)
-{
- pr_warn("kernel not built with CONFIG_DYNAMIC_DEBUG_CORE\n");
- return 0;
-}
-
#endif /* !CONFIG_DYNAMIC_DEBUG_CORE */
#endif
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 5a849716220a..e96dc216463b 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -558,35 +558,6 @@ static int ddebug_exec_queries(char *query, const char *modname)
return nfound;
}
-/**
- * dynamic_debug_exec_queries - select and change dynamic-debug prints
- * @query: query-string described in admin-guide/dynamic-debug-howto
- * @modname: string containing module name, usually &module.mod_name
- *
- * This uses the >/proc/dynamic_debug/control reader, allowing module
- * authors to modify their dynamic-debug callsites. The modname is
- * canonically struct module.mod_name, but can also be null or a
- * module-wildcard, for example: "drm*".
- */
-int dynamic_debug_exec_queries(const char *query, const char *modname)
-{
- int rc;
- char *qry; /* writable copy of query */
-
- if (!query) {
- pr_err("non-null query/command string expected\n");
- return -EINVAL;
- }
- qry = kstrndup(query, PAGE_SIZE, GFP_KERNEL);
- if (!qry)
- return -ENOMEM;
-
- rc = ddebug_exec_queries(qry, modname);
- kfree(qry);
- return rc;
-}
-EXPORT_SYMBOL_GPL(dynamic_debug_exec_queries);
-
#define PREFIX_SIZE 64
static int remaining(int wrote)
--
2.37.1
next prev parent reply other threads:[~2022-08-11 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 17:35 [PATCH 00/11] DYNAMIC_DEBUG for this cycle Jim Cromie
2022-08-11 17:35 ` [PATCH 01/11] dyndbg: fix static_branch manipulation Jim Cromie
2022-08-11 17:35 ` [PATCH 02/11] dyndbg: fix module.dyndbg handling Jim Cromie
2022-08-11 17:35 ` [PATCH 03/11] dyndbg: show both old and new in change-info Jim Cromie
2022-08-11 17:35 ` [PATCH 04/11] dyndbg: reverse module walk in cat control Jim Cromie
2022-08-11 17:35 ` [PATCH 05/11] dyndbg: reverse module.callsite " Jim Cromie
2022-08-11 17:35 ` [PATCH 06/11] dyndbg: use ESCAPE_SPACE for " Jim Cromie
2022-08-11 17:35 ` [PATCH 07/11] dyndbg: let query-modname override actual module name Jim Cromie
2022-08-11 17:35 ` [PATCH 08/11] dyndbg: add test_dynamic_debug module Jim Cromie
2022-08-11 17:35 ` Jim Cromie [this message]
2022-08-11 17:35 ` [PATCH 10/11] dyndbg: cleanup auto vars in dynamic_debug_init Jim Cromie
2022-08-11 17:35 ` [PATCH 11/11] dyndbg: create and use struct _ddebug_info Jim Cromie
2022-08-12 5:37 ` [PATCH 00/11] DYNAMIC_DEBUG for this cycle Greg KH
2022-09-01 16:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811173541.2901122-10-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®