From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jbaron@akamai.com
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 03/11] dyndbg: show both old and new in change-info
Date: Thu, 11 Aug 2022 11:35:33 -0600 [thread overview]
Message-ID: <20220811173541.2901122-4-jim.cromie@gmail.com> (raw)
In-Reply-To: <20220811173541.2901122-1-jim.cromie@gmail.com>
print "old => new" flag values to the info("change") message.
no functional change.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Acked-by: Jason Baron <jbaron@akamai.com>
---
lib/dynamic_debug.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index a56c1286ffa4..8faf584f2f4b 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -156,7 +156,7 @@ static int ddebug_change(const struct ddebug_query *query,
struct ddebug_table *dt;
unsigned int newflags;
unsigned int nfound = 0;
- struct flagsbuf fbuf;
+ struct flagsbuf fbuf, nbuf;
/* search for matching ddebugs */
mutex_lock(&ddebug_lock);
@@ -217,11 +217,12 @@ static int ddebug_change(const struct ddebug_query *query,
static_branch_enable(&dp->key.dd_key_true);
}
#endif
+ v4pr_info("changed %s:%d [%s]%s %s => %s\n",
+ trim_prefix(dp->filename), dp->lineno,
+ dt->mod_name, dp->function,
+ ddebug_describe_flags(dp->flags, &fbuf),
+ ddebug_describe_flags(newflags, &nbuf));
dp->flags = newflags;
- v4pr_info("changed %s:%d [%s]%s =%s\n",
- trim_prefix(dp->filename), dp->lineno,
- dt->mod_name, dp->function,
- ddebug_describe_flags(dp->flags, &fbuf));
}
}
mutex_unlock(&ddebug_lock);
--
2.37.1
next prev parent reply other threads:[~2022-08-11 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 17:35 [PATCH 00/11] DYNAMIC_DEBUG for this cycle Jim Cromie
2022-08-11 17:35 ` [PATCH 01/11] dyndbg: fix static_branch manipulation Jim Cromie
2022-08-11 17:35 ` [PATCH 02/11] dyndbg: fix module.dyndbg handling Jim Cromie
2022-08-11 17:35 ` Jim Cromie [this message]
2022-08-11 17:35 ` [PATCH 04/11] dyndbg: reverse module walk in cat control Jim Cromie
2022-08-11 17:35 ` [PATCH 05/11] dyndbg: reverse module.callsite " Jim Cromie
2022-08-11 17:35 ` [PATCH 06/11] dyndbg: use ESCAPE_SPACE for " Jim Cromie
2022-08-11 17:35 ` [PATCH 07/11] dyndbg: let query-modname override actual module name Jim Cromie
2022-08-11 17:35 ` [PATCH 08/11] dyndbg: add test_dynamic_debug module Jim Cromie
2022-08-11 17:35 ` [PATCH 09/11] dyndbg: drop EXPORTed dynamic_debug_exec_queries Jim Cromie
2022-08-11 17:35 ` [PATCH 10/11] dyndbg: cleanup auto vars in dynamic_debug_init Jim Cromie
2022-08-11 17:35 ` [PATCH 11/11] dyndbg: create and use struct _ddebug_info Jim Cromie
2022-08-12 5:37 ` [PATCH 00/11] DYNAMIC_DEBUG for this cycle Greg KH
2022-09-01 16:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811173541.2901122-4-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®