mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	jbaron@akamai.com
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 06/11] dyndbg: use ESCAPE_SPACE for cat control
Date: Thu, 11 Aug 2022 11:35:36 -0600	[thread overview]
Message-ID: <20220811173541.2901122-7-jim.cromie@gmail.com> (raw)
In-Reply-To: <20220811173541.2901122-1-jim.cromie@gmail.com>

`cat control` currently does octal escape, so '\n' becomes "\012".
Change this to display as "\n" instead, which reads much cleaner.

   :#> head -n7 /proc/dynamic_debug/control
   # filename:lineno [module]function flags format
   init/main.c:1179 [main]initcall_blacklist =_ "blacklisting initcall %s\n"
   init/main.c:1218 [main]initcall_blacklisted =_ "initcall %s blacklisted\n"
   init/main.c:1424 [main]run_init_process =_ "  with arguments:\n"
   init/main.c:1426 [main]run_init_process =_ "    %s\n"
   init/main.c:1427 [main]run_init_process =_ "  with environment:\n"
   init/main.c:1429 [main]run_init_process =_ "    %s\n"

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Acked-by: Jason Baron <jbaron@akamai.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8ff11977b8bd..e5cbe603000c 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -900,7 +900,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		   trim_prefix(dp->filename), dp->lineno,
 		   iter->table->mod_name, dp->function,
 		   ddebug_describe_flags(dp->flags, &flags));
-	seq_escape(m, dp->format, "\t\r\n\"");
+	seq_escape_str(m, dp->format, ESCAPE_SPACE, "\t\r\n\"");
 	seq_puts(m, "\"\n");
 
 	return 0;
-- 
2.37.1


  parent reply	other threads:[~2022-08-11 17:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 17:35 [PATCH 00/11] DYNAMIC_DEBUG for this cycle Jim Cromie
2022-08-11 17:35 ` [PATCH 01/11] dyndbg: fix static_branch manipulation Jim Cromie
2022-08-11 17:35 ` [PATCH 02/11] dyndbg: fix module.dyndbg handling Jim Cromie
2022-08-11 17:35 ` [PATCH 03/11] dyndbg: show both old and new in change-info Jim Cromie
2022-08-11 17:35 ` [PATCH 04/11] dyndbg: reverse module walk in cat control Jim Cromie
2022-08-11 17:35 ` [PATCH 05/11] dyndbg: reverse module.callsite " Jim Cromie
2022-08-11 17:35 ` Jim Cromie [this message]
2022-08-11 17:35 ` [PATCH 07/11] dyndbg: let query-modname override actual module name Jim Cromie
2022-08-11 17:35 ` [PATCH 08/11] dyndbg: add test_dynamic_debug module Jim Cromie
2022-08-11 17:35 ` [PATCH 09/11] dyndbg: drop EXPORTed dynamic_debug_exec_queries Jim Cromie
2022-08-11 17:35 ` [PATCH 10/11] dyndbg: cleanup auto vars in dynamic_debug_init Jim Cromie
2022-08-11 17:35 ` [PATCH 11/11] dyndbg: create and use struct _ddebug_info Jim Cromie
2022-08-12  5:37 ` [PATCH 00/11] DYNAMIC_DEBUG for this cycle Greg KH
2022-09-01 16:10 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811173541.2901122-7-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®