mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] cgroup/cpuset: remove unreachable code
@ 2022-09-07  4:01 Jiapeng Chong
  2022-09-07 15:32 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-09-07  4:01 UTC (permalink / raw)
  To: lizefan.x; +Cc: tj, hannes, cgroups, linux-kernel, Jiapeng Chong, Abaci Robot

The function sched_partition_show cannot execute seq_puts, delete the
invalid code.

kernel/cgroup/cpuset.c:2849 sched_partition_show() warn: ignoring unreachable code.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2087
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 kernel/cgroup/cpuset.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 6baa977a71ba..b474289c15b8 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2846,8 +2846,6 @@ static int sched_partition_show(struct seq_file *seq, void *v)
 		else
 			seq_printf(seq, "%s invalid\n", type);
 		break;
-		seq_puts(seq, "isolated invalid\n");
-		break;
 	}
 	return 0;
 }
-- 
2.20.1.7.g153144c


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cgroup/cpuset: remove unreachable code
  2022-09-07  4:01 [PATCH] cgroup/cpuset: remove unreachable code Jiapeng Chong
@ 2022-09-07 15:32 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2022-09-07 15:32 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: lizefan.x, hannes, cgroups, linux-kernel, Abaci Robot, Waiman Long

(cc'ing Waiman and quoting the whole message)

On Wed, Sep 07, 2022 at 12:01:12PM +0800, Jiapeng Chong wrote:
> The function sched_partition_show cannot execute seq_puts, delete the
> invalid code.
> 
> kernel/cgroup/cpuset.c:2849 sched_partition_show() warn: ignoring unreachable code.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2087
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---

Applied to cgroup/for-6.1.

Thanks.

>  kernel/cgroup/cpuset.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 6baa977a71ba..b474289c15b8 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -2846,8 +2846,6 @@ static int sched_partition_show(struct seq_file *seq, void *v)
>  		else
>  			seq_printf(seq, "%s invalid\n", type);
>  		break;
> -		seq_puts(seq, "isolated invalid\n");
> -		break;
>  	}
>  	return 0;
>  }
> -- 
> 2.20.1.7.g153144c
> 

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-07 15:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07  4:01 [PATCH] cgroup/cpuset: remove unreachable code Jiapeng Chong
2022-09-07 15:32 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®