* [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method
@ 2022-10-18 15:28 Rafael Mendonca
2022-10-18 16:45 ` Eric Auger
2022-11-10 20:16 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Rafael Mendonca @ 2022-10-18 15:28 UTC (permalink / raw)
To: Eric Auger, Alex Williamson, Cornelia Huck, Sinan Kaya
Cc: Rafael Mendonca, kvm, linux-kernel
The ACPI _RST method has no return value, there's no need to pass a return
buffer to acpi_evaluate_object().
Fixes: d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
---
drivers/vfio/platform/vfio_platform_common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index 55dc4f43c31e..1a0a238ffa35 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
const char **extra_dbg)
{
#ifdef CONFIG_ACPI
- struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
struct device *dev = vdev->device;
acpi_handle handle = ACPI_HANDLE(dev);
acpi_status acpi_ret;
- acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
+ acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, NULL);
if (ACPI_FAILURE(acpi_ret)) {
if (extra_dbg)
*extra_dbg = acpi_format_exception(acpi_ret);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method
2022-10-18 15:28 [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method Rafael Mendonca
@ 2022-10-18 16:45 ` Eric Auger
2022-11-10 20:16 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Eric Auger @ 2022-10-18 16:45 UTC (permalink / raw)
To: Rafael Mendonca, Alex Williamson, Cornelia Huck, Sinan Kaya
Cc: kvm, linux-kernel
Hi Rafael,
On 10/18/22 17:28, Rafael Mendonca wrote:
> The ACPI _RST method has no return value, there's no need to pass a return
> buffer to acpi_evaluate_object().
>
> Fixes: d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> drivers/vfio/platform/vfio_platform_common.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 55dc4f43c31e..1a0a238ffa35 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> const char **extra_dbg)
> {
> #ifdef CONFIG_ACPI
> - struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> struct device *dev = vdev->device;
> acpi_handle handle = ACPI_HANDLE(dev);
> acpi_status acpi_ret;
>
> - acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
> + acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, NULL);
> if (ACPI_FAILURE(acpi_ret)) {
> if (extra_dbg)
> *extra_dbg = acpi_format_exception(acpi_ret);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method
2022-10-18 15:28 [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method Rafael Mendonca
2022-10-18 16:45 ` Eric Auger
@ 2022-11-10 20:16 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2022-11-10 20:16 UTC (permalink / raw)
To: Rafael Mendonca; +Cc: Eric Auger, Cornelia Huck, Sinan Kaya, kvm, linux-kernel
On Tue, 18 Oct 2022 12:28:25 -0300
Rafael Mendonca <rafaelmendsr@gmail.com> wrote:
> The ACPI _RST method has no return value, there's no need to pass a return
> buffer to acpi_evaluate_object().
>
> Fixes: d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/vfio/platform/vfio_platform_common.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 55dc4f43c31e..1a0a238ffa35 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> const char **extra_dbg)
> {
> #ifdef CONFIG_ACPI
> - struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> struct device *dev = vdev->device;
> acpi_handle handle = ACPI_HANDLE(dev);
> acpi_status acpi_ret;
>
> - acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
> + acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, NULL);
> if (ACPI_FAILURE(acpi_ret)) {
> if (extra_dbg)
> *extra_dbg = acpi_format_exception(acpi_ret);
Applied to vfio next branch for v6.2. Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-10 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 15:28 [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method Rafael Mendonca
2022-10-18 16:45 ` Eric Auger
2022-11-10 20:16 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®