* [PATCH] media: mc: entity: Fix doc for media_graph_walk_init
@ 2022-12-17 14:31 Miaoqian Lin
2022-12-18 14:22 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-12-17 14:31 UTC (permalink / raw)
To: Sakari Ailus, Laurent Pinchart, Mauro Carvalho Chehab,
linux-media, linux-kernel
Cc: linmq006
There is no media_graph_walk_free(). media_graph_walk_cleanup() is used
to release the resources.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/media/mc/mc-entity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
index b8bcbc734eaf..de25de328fbe 100644
--- a/drivers/media/mc/mc-entity.c
+++ b/drivers/media/mc/mc-entity.c
@@ -295,7 +295,7 @@ static struct media_entity *stack_pop(struct media_graph *graph)
*
* Reserve resources for graph walk in media device's current
* state. The memory must be released using
- * media_graph_walk_free().
+ * media_graph_walk_cleanup().
*
* Returns error on failure, zero on success.
*/
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: mc: entity: Fix doc for media_graph_walk_init
2022-12-17 14:31 [PATCH] media: mc: entity: Fix doc for media_graph_walk_init Miaoqian Lin
@ 2022-12-18 14:22 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2022-12-18 14:22 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Sakari Ailus, Mauro Carvalho Chehab, linux-media, linux-kernel
Hi Miaoqian,
Thank you for the patch.
On Sat, Dec 17, 2022 at 06:31:13PM +0400, Miaoqian Lin wrote:
> There is no media_graph_walk_free(). media_graph_walk_cleanup() is used
> to release the resources.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/mc/mc-entity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index b8bcbc734eaf..de25de328fbe 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -295,7 +295,7 @@ static struct media_entity *stack_pop(struct media_graph *graph)
> *
> * Reserve resources for graph walk in media device's current
> * state. The memory must be released using
> - * media_graph_walk_free().
> + * media_graph_walk_cleanup().
> *
> * Returns error on failure, zero on success.
> */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-18 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-17 14:31 [PATCH] media: mc: entity: Fix doc for media_graph_walk_init Miaoqian Lin
2022-12-18 14:22 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®