* [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()
@ 2022-12-27 8:21 Jiapeng Chong
2023-01-04 8:31 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-12-27 8:21 UTC (permalink / raw)
To: jgross
Cc: boris.ostrovsky, tglx, mingo, bp, dave.hansen, x86, hpa,
xen-devel, linux-kernel, Jiapeng Chong, Abaci Robot
The function p2m_top_mfn_init is defined in the p2m.c file,
but not called elsewhere, so remove this unused function.
arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3557
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
arch/x86/xen/p2m.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 58db86f7b384..9bdc3b656b2c 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -134,11 +134,6 @@ static inline unsigned p2m_mid_index(unsigned long pfn)
return (pfn / P2M_PER_PAGE) % P2M_MID_PER_PAGE;
}
-static inline unsigned p2m_index(unsigned long pfn)
-{
- return pfn % P2M_PER_PAGE;
-}
-
static void p2m_top_mfn_init(unsigned long *top)
{
unsigned i;
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()
2022-12-27 8:21 [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init() Jiapeng Chong
@ 2023-01-04 8:31 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2023-01-04 8:31 UTC (permalink / raw)
To: Jiapeng Chong
Cc: boris.ostrovsky, tglx, mingo, bp, dave.hansen, x86, hpa,
xen-devel, linux-kernel, Abaci Robot, jgross
On 27.12.2022 09:21, Jiapeng Chong wrote:
> The function p2m_top_mfn_init is defined in the p2m.c file,
> but not called elsewhere, so remove this unused function.
This and the title are wrong - p2m_top_mfn_init() is used by
xen_build_mfn_list_list().
> arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.
Whereas this and the actual code change look correct to me.
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-04 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-27 8:21 [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init() Jiapeng Chong
2023-01-04 8:31 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®