* [RFT PATCH] arm64: dts: qcom: sc8280xp: remove GCC from CX power domain
@ 2022-12-30 15:55 Krzysztof Kozlowski
2022-12-30 17:16 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-30 15:55 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings do not allow power-domain property in GCC clock controller and
documentation does not indicate that GCC is part of VDD_CX.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Maybe the bindings should be fixed? Maybe this was added as workaround?
Anyway looking at documentation I do not see such relation, except
downstream vdd_cx-supply (which is the same as in other SoCs and we do
not represent it in upstream).
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 1d1420c8720c..d14663c9f34c 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -799,7 +799,6 @@ gcc: clock-controller@100000 {
<&pcie4_phy>,
<0>,
<0>;
- power-domains = <&rpmhpd SC8280XP_CX>;
};
ipcc: mailbox@408000 {
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFT PATCH] arm64: dts: qcom: sc8280xp: remove GCC from CX power domain
2022-12-30 15:55 [RFT PATCH] arm64: dts: qcom: sc8280xp: remove GCC from CX power domain Krzysztof Kozlowski
@ 2022-12-30 17:16 ` Bjorn Andersson
2023-01-02 8:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2022-12-30 17:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
On Fri, Dec 30, 2022 at 04:55:02PM +0100, Krzysztof Kozlowski wrote:
> Bindings do not allow power-domain property in GCC clock controller and
> documentation does not indicate that GCC is part of VDD_CX.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Maybe the bindings should be fixed? Maybe this was added as workaround?
> Anyway looking at documentation I do not see such relation, except
> downstream vdd_cx-supply (which is the same as in other SoCs and we do
> not represent it in upstream).
The GCC itself is powered by CX and the GDSC power-domains exposed by
GCC are powered by CX.
It's fairly recently that we started attempting to scale CX - and
attempted to suspend things. But this is probably how it should be
represented on all platforms.
So let's fix the binding instead.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 1d1420c8720c..d14663c9f34c 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -799,7 +799,6 @@ gcc: clock-controller@100000 {
> <&pcie4_phy>,
> <0>,
> <0>;
> - power-domains = <&rpmhpd SC8280XP_CX>;
> };
>
> ipcc: mailbox@408000 {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFT PATCH] arm64: dts: qcom: sc8280xp: remove GCC from CX power domain
2022-12-30 17:16 ` Bjorn Andersson
@ 2023-01-02 8:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-02 8:42 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
On 30/12/2022 18:16, Bjorn Andersson wrote:
> On Fri, Dec 30, 2022 at 04:55:02PM +0100, Krzysztof Kozlowski wrote:
>> Bindings do not allow power-domain property in GCC clock controller and
>> documentation does not indicate that GCC is part of VDD_CX.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Maybe the bindings should be fixed? Maybe this was added as workaround?
>> Anyway looking at documentation I do not see such relation, except
>> downstream vdd_cx-supply (which is the same as in other SoCs and we do
>> not represent it in upstream).
>
> The GCC itself is powered by CX and the GDSC power-domains exposed by
> GCC are powered by CX.
>
> It's fairly recently that we started attempting to scale CX - and
> attempted to suspend things. But this is probably how it should be
> represented on all platforms.
>
>
> So let's fix the binding instead.
Sure.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-02 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-30 15:55 [RFT PATCH] arm64: dts: qcom: sc8280xp: remove GCC from CX power domain Krzysztof Kozlowski
2022-12-30 17:16 ` Bjorn Andersson
2023-01-02 8:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®