[PATCH v3 0/2] kheaders: use standard naming for the temporary directory

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH v3 0/2] kheaders: use standard naming for the temporary directory
@ 2023-01-18  5:05 Thomas Weißschuh
  2023-01-18  5:05 ` [PATCH v3 1/2] kbuild: also delete temporary directories Thomas Weißschuh
  2023-01-18  5:05 ` [PATCH v3 2/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Weißschuh @ 2023-01-18  5:05 UTC (permalink / raw)
  To: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers, Nicolas Schier
  Cc: linux-kernel, linux-kbuild, Nicolas Schier, Thomas Weißschuh

To: Masahiro Yamada <masahiroy@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
To: Nicolas Schier <nicolas@fjasle.eu>
Cc: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org
Cc: Nicolas Schier <n.schier@avm.de>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Changes in v3:
- Use standard naming schema for temporary directories
- Modify toplevel Makefile to also clean temporary directories
- Link to v2: https://lore.kernel.org/r/20230117-kernel-kheaders-gitignore-v2-1-1c29b3adf04a@weissschuh.net

Changes in v2:
- Also add the directory to clean-files
- Link to v1: https://lore.kernel.org/r/20230117-kernel-kheaders-gitignore-v1-1-2a3a070efd0d@weissschuh.net

---
Thomas Weißschuh (2):
      kbuild: also delete temporary directories
      kheaders: use standard naming for the temporary directory

 Makefile               | 5 +++--
 kernel/gen_kheaders.sh | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: c1649ec55708ae42091a2f1bca1ab49ecd722d55
change-id: 20230117-kernel-kheaders-gitignore-f0d73456cb6b

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 1/2] kbuild: also delete temporary directories
  2023-01-18  5:05 [PATCH v3 0/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
@ 2023-01-18  5:05 ` Thomas Weißschuh
  2023-01-18  7:54   ` Nicolas Schier
  2023-01-18  5:05 ` [PATCH v3 2/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Weißschuh @ 2023-01-18  5:05 UTC (permalink / raw)
  To: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers, Nicolas Schier
  Cc: linux-kernel, linux-kbuild, Nicolas Schier, Thomas Weißschuh

Reuse the standard naming schema for temporary files also for temporary
directories.

Such a directory will be used by the kheaders generation.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index e09fe100efb2..863b3fdd4374 100644
--- a/Makefile
+++ b/Makefile
@@ -2026,11 +2026,12 @@ clean: $(clean-dirs)
 		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
 		-o -name '*.asn1.[ch]' \
 		-o -name '*.symtypes' -o -name 'modules.order' \
-		-o -name '.tmp_*' \
 		-o -name '*.c.[012]*.*' \
 		-o -name '*.ll' \
 		-o -name '*.gcno' \
-		-o -name '*.*.symversions' \) -type f -print | xargs rm -f
+		-o -name '*.*.symversions' \) -type f -print \
+		-o -name '.tmp_*' -print \
+		| xargs rm -rf
 
 # Generate tags for editors
 # ---------------------------------------------------------------------------

-- 
2.39.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] kbuild: also delete temporary directories
  2023-01-18  5:05 ` [PATCH v3 1/2] kbuild: also delete temporary directories Thomas Weißschuh
@ 2023-01-18  7:54   ` Nicolas Schier
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Schier @ 2023-01-18  7:54 UTC (permalink / raw)
  To: Thomas Weißschuh
  Cc: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
	linux-kernel, linux-kbuild

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On Wed 18 Jan 2023 05:05:34 GMT, Thomas Weißschuh wrote:
> Reuse the standard naming schema for temporary files also for 
> temporary
> directories.
> 
> Such a directory will be used by the kheaders generation.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>  Makefile | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index e09fe100efb2..863b3fdd4374 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2026,11 +2026,12 @@ clean: $(clean-dirs)
>  		-o -name '*.lex.c' -o -name '*.tab.[ch]' \
>  		-o -name '*.asn1.[ch]' \
>  		-o -name '*.symtypes' -o -name 'modules.order' \
> -		-o -name '.tmp_*' \
>  		-o -name '*.c.[012]*.*' \
>  		-o -name '*.ll' \
>  		-o -name '*.gcno' \
> -		-o -name '*.*.symversions' \) -type f -print | xargs rm -f
> +		-o -name '*.*.symversions' \) -type f -print \
> +		-o -name '.tmp_*' -print \
> +		| xargs rm -rf
>  
>  # Generate tags for editors
>  # ---------------------------------------------------------------------------
> 
> -- 
> 2.39.1

Thanks!

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] kheaders: use standard naming for the temporary directory
  2023-01-18  5:05 [PATCH v3 0/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
  2023-01-18  5:05 ` [PATCH v3 1/2] kbuild: also delete temporary directories Thomas Weißschuh
@ 2023-01-18  5:05 ` Thomas Weißschuh
  2023-01-18  7:55   ` Nicolas Schier
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Weißschuh @ 2023-01-18  5:05 UTC (permalink / raw)
  To: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers, Nicolas Schier
  Cc: linux-kernel, linux-kbuild, Nicolas Schier, Thomas Weißschuh

If the kheaders archive generation is interrupted then this directory
may be left on disk and not ignored by git.
By using the standard naming schema for temporary files and directories
the default .gitignore and "make clean" rules will apply.

Suggested-by: Nicolas Schier <nicolas@fjasle.eu>
Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 kernel/gen_kheaders.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
index 473036b43c83..b477b763f262 100755
--- a/kernel/gen_kheaders.sh
+++ b/kernel/gen_kheaders.sh
@@ -7,7 +7,7 @@ set -e
 sfile="$(readlink -f "$0")"
 outdir="$(pwd)"
 tarfile=$1
-cpio_dir=$outdir/$tarfile.tmp
+cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir
 
 dir_list="
 include/

-- 
2.39.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] kheaders: use standard naming for the temporary directory
  2023-01-18  5:05 ` [PATCH v3 2/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
@ 2023-01-18  7:55   ` Nicolas Schier
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Schier @ 2023-01-18  7:55 UTC (permalink / raw)
  To: Thomas Weißschuh
  Cc: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
	linux-kernel, linux-kbuild

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

On Wed 18 Jan 2023 05:05:35 GMT, Thomas Weißschuh wrote:
> If the kheaders archive generation is interrupted then this directory
> may be left on disk and not ignored by git.
> By using the standard naming schema for temporary files and directories
> the default .gitignore and "make clean" rules will apply.
> 
> Suggested-by: Nicolas Schier <nicolas@fjasle.eu>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>  kernel/gen_kheaders.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
> index 473036b43c83..b477b763f262 100755
> --- a/kernel/gen_kheaders.sh
> +++ b/kernel/gen_kheaders.sh
> @@ -7,7 +7,7 @@ set -e
>  sfile="$(readlink -f "$0")"
>  outdir="$(pwd)"
>  tarfile=$1
> -cpio_dir=$outdir/$tarfile.tmp
> +cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir
>  
>  dir_list="
>  include/
> 
> -- 
> 2.39.1

Thanks!

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 0/2] kheaders: use standard naming for the temporary directory
@ 2023-01-18  5:04 Thomas Weißschuh
  2023-01-18  5:04 ` [PATCH v3 2/2] " Thomas Weißschuh
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Weißschuh @ 2023-01-18  5:04 UTC (permalink / raw)
  To: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers, Nicolas Schier
  Cc: linux-kernel, linux-kbuild, Nicolas Schier, Thomas Weißschuh

To: Masahiro Yamada <masahiroy@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
To: Nicolas Schier <nicolas@fjasle.eu>
Cc: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org
Cc: Nicolas Schier <n.schier@avm.de>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Changes in v3:
- Use standard naming schema for temporary directories
- Modify toplevel Makefile to also clean temporary directories
- Link to v2: https://lore.kernel.org/r/20230117-kernel-kheaders-gitignore-v2-1-1c29b3adf04a@weissschuh.net

Changes in v2:
- Also add the directory to clean-files
- Link to v1: https://lore.kernel.org/r/20230117-kernel-kheaders-gitignore-v1-1-2a3a070efd0d@weissschuh.net

---
Thomas Weißschuh (2):
      kbuild: also delete temporary directories
      kheaders: use standard naming for the temporary directory

 Makefile               | 5 +++--
 kernel/gen_kheaders.sh | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: c1649ec55708ae42091a2f1bca1ab49ecd722d55
change-id: 20230117-kernel-kheaders-gitignore-f0d73456cb6b

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] kheaders: use standard naming for the temporary directory
  2023-01-18  5:04 [PATCH v3 0/2] " Thomas Weißschuh
@ 2023-01-18  5:04 ` Thomas Weißschuh
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Weißschuh @ 2023-01-18  5:04 UTC (permalink / raw)
  To: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers, Nicolas Schier
  Cc: linux-kernel, linux-kbuild, Nicolas Schier, Thomas Weißschuh

If the kheaders archive generation is interrupted then this directory
may be left on disk and not ignored by git.
By using the standard naming schema for temporary files and directories
the default .gitignore and "make clean" rules will apply.

Suggested-by: Nicolas Schier <nicolas@fjasle.eu>
Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 kernel/gen_kheaders.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
index 473036b43c83..b477b763f262 100755
--- a/kernel/gen_kheaders.sh
+++ b/kernel/gen_kheaders.sh
@@ -7,7 +7,7 @@ set -e
 sfile="$(readlink -f "$0")"
 outdir="$(pwd)"
 tarfile=$1
-cpio_dir=$outdir/$tarfile.tmp
+cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir
 
 dir_list="
 include/

-- 
2.39.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-01-18  8:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18  5:05 [PATCH v3 0/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
2023-01-18  5:05 ` [PATCH v3 1/2] kbuild: also delete temporary directories Thomas Weißschuh
2023-01-18  7:54   ` Nicolas Schier
2023-01-18  5:05 ` [PATCH v3 2/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
2023-01-18  7:55   ` Nicolas Schier
  -- strict thread matches above, loose matches on Subject: below --
2023-01-18  5:04 [PATCH v3 0/2] " Thomas Weißschuh
2023-01-18  5:04 ` [PATCH v3 2/2] " Thomas Weißschuh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®