* [PATCH v1] perf tools: Fix foolproof typo
@ 2023-01-19 20:10 Ian Rogers
2023-01-19 20:14 ` Liang, Kan
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2023-01-19 20:10 UTC (permalink / raw)
To: Kan Liang
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Leo Yan, Ali Saidi, Ravi Bangoria, James Clark, Adrian Hunter,
Sandipan Das, linux-perf-users, linux-kernel, Ian Rogers
In the context of LBR stitching documentation.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/Documentation/perf-c2c.txt | 2 +-
tools/perf/Documentation/perf-report.txt | 2 +-
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/Documentation/perf-top.txt | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt
index 5c5eb2def83e..af5c3106f468 100644
--- a/tools/perf/Documentation/perf-c2c.txt
+++ b/tools/perf/Documentation/perf-c2c.txt
@@ -121,7 +121,7 @@ REPORT OPTIONS
perf c2c record --call-graph lbr.
Disabled by default. In common cases with call stack overflows,
it can recreate better call stacks than the default lbr call stack
- output. But this approach is not full proof. There can be cases
+ output. But this approach is not foolproof. There can be cases
where it creates incorrect call stacks from incorrect matches.
The known limitations include exception handing such as
setjmp/longjmp will have calls/returns not match.
diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 4fa509b15948..9b0c0dbf9a77 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -507,7 +507,7 @@ include::itrace.txt[]
perf record --call-graph lbr.
Disabled by default. In common cases with call stack overflows,
it can recreate better call stacks than the default lbr call stack
- output. But this approach is not full proof. There can be cases
+ output. But this approach is not foolproof. There can be cases
where it creates incorrect call stacks from incorrect matches.
The known limitations include exception handing such as
setjmp/longjmp will have calls/returns not match.
diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
index 68e37de5fae4..8d77182fbf31 100644
--- a/tools/perf/Documentation/perf-script.txt
+++ b/tools/perf/Documentation/perf-script.txt
@@ -502,7 +502,7 @@ include::itrace.txt[]
perf record --call-graph lbr.
Disabled by default. In common cases with call stack overflows,
it can recreate better call stacks than the default lbr call stack
- output. But this approach is not full proof. There can be cases
+ output. But this approach is not foolproof. There can be cases
where it creates incorrect call stacks from incorrect matches.
The known limitations include exception handing such as
setjmp/longjmp will have calls/returns not match.
diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index e534d709cc5a..c60e615b7183 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -334,7 +334,7 @@ use '-e e1 -e e2 -G foo,foo' or just use '-e e1 -e e2 -G foo'.
callgraph. The option must be used with --call-graph lbr recording.
Disabled by default. In common cases with call stack overflows,
it can recreate better call stacks than the default lbr call stack
- output. But this approach is not full proof. There can be cases
+ output. But this approach is not foolproof. There can be cases
where it creates incorrect call stacks from incorrect matches.
The known limitations include exception handing such as
setjmp/longjmp will have calls/returns not match.
--
2.39.0.246.g2a6d74b583-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] perf tools: Fix foolproof typo
2023-01-19 20:10 [PATCH v1] perf tools: Fix foolproof typo Ian Rogers
@ 2023-01-19 20:14 ` Liang, Kan
0 siblings, 0 replies; 2+ messages in thread
From: Liang, Kan @ 2023-01-19 20:14 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Leo Yan, Ali Saidi, Ravi Bangoria, James Clark, Adrian Hunter,
Sandipan Das, linux-perf-users, linux-kernel
On 2023-01-19 3:10 p.m., Ian Rogers wrote:
> In the context of LBR stitching documentation.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Thanks Ian.
Acked-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
> tools/perf/Documentation/perf-c2c.txt | 2 +-
> tools/perf/Documentation/perf-report.txt | 2 +-
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/Documentation/perf-top.txt | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt
> index 5c5eb2def83e..af5c3106f468 100644
> --- a/tools/perf/Documentation/perf-c2c.txt
> +++ b/tools/perf/Documentation/perf-c2c.txt
> @@ -121,7 +121,7 @@ REPORT OPTIONS
> perf c2c record --call-graph lbr.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 4fa509b15948..9b0c0dbf9a77 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -507,7 +507,7 @@ include::itrace.txt[]
> perf record --call-graph lbr.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
> diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
> index 68e37de5fae4..8d77182fbf31 100644
> --- a/tools/perf/Documentation/perf-script.txt
> +++ b/tools/perf/Documentation/perf-script.txt
> @@ -502,7 +502,7 @@ include::itrace.txt[]
> perf record --call-graph lbr.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index e534d709cc5a..c60e615b7183 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -334,7 +334,7 @@ use '-e e1 -e e2 -G foo,foo' or just use '-e e1 -e e2 -G foo'.
> callgraph. The option must be used with --call-graph lbr recording.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-19 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 20:10 [PATCH v1] perf tools: Fix foolproof typo Ian Rogers
2023-01-19 20:14 ` Liang, Kan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®