* [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr
@ 2023-02-15 21:47 Guenter Roeck
2023-02-16 17:22 ` Joe Tessler
2023-03-08 18:21 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-02-15 21:47 UTC (permalink / raw)
To: Joe Tessler
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media, linux-kernel,
Guenter Roeck, Joshua Pius
The driver does not instantiate on ACPI based systems if OF is disabled.
Fix the problem by dropping of_match_ptr.
Cc: Joshua Pius <joshuapius@google.com>
Tested-by: Joshua Pius <joshuapius@google.com>
Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Added Joshua's Tested-by: tag
drivers/media/cec/i2c/ch7322.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
index 34fad7123704..3c6e6496a001 100644
--- a/drivers/media/cec/i2c/ch7322.c
+++ b/drivers/media/cec/i2c/ch7322.c
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
static struct i2c_driver ch7322_i2c_driver = {
.driver = {
.name = "ch7322",
- .of_match_table = of_match_ptr(ch7322_of_match),
+ .of_match_table = ch7322_of_match,
},
.probe_new = ch7322_probe,
.remove = ch7322_remove,
--
2.39.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr
2023-02-15 21:47 [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr Guenter Roeck
@ 2023-02-16 17:22 ` Joe Tessler
2023-03-08 18:21 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Joe Tessler @ 2023-02-16 17:22 UTC (permalink / raw)
To: Guenter Roeck
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media, linux-kernel,
Joshua Pius
Hey Guenter,
Thank you for this fix.
On Wed, Feb 15, 2023 at 4:47 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> The driver does not instantiate on ACPI based systems if OF is disabled.
> Fix the problem by dropping of_match_ptr.
>
> Cc: Joshua Pius <joshuapius@google.com>
> Tested-by: Joshua Pius <joshuapius@google.com>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Joe Tessler <jrt@google.com>
> ---
> v2: Added Joshua's Tested-by: tag
>
> drivers/media/cec/i2c/ch7322.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
> index 34fad7123704..3c6e6496a001 100644
> --- a/drivers/media/cec/i2c/ch7322.c
> +++ b/drivers/media/cec/i2c/ch7322.c
> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
> static struct i2c_driver ch7322_i2c_driver = {
> .driver = {
> .name = "ch7322",
> - .of_match_table = of_match_ptr(ch7322_of_match),
> + .of_match_table = ch7322_of_match,
> },
> .probe_new = ch7322_probe,
> .remove = ch7322_remove,
> --
> 2.39.1
>
Joe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr
2023-02-15 21:47 [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr Guenter Roeck
2023-02-16 17:22 ` Joe Tessler
@ 2023-03-08 18:21 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-03-08 18:21 UTC (permalink / raw)
To: Joe Tessler
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media, linux-kernel,
Joshua Pius
On Wed, Feb 15, 2023 at 01:47:24PM -0800, Guenter Roeck wrote:
> The driver does not instantiate on ACPI based systems if OF is disabled.
> Fix the problem by dropping of_match_ptr.
>
This patch has still not been applied, so ... ping ...
Is there anything else I need to do to get it applied ?
Thanks,
Guenter
> Cc: Joshua Pius <joshuapius@google.com>
> Tested-by: Joshua Pius <joshuapius@google.com>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Added Joshua's Tested-by: tag
>
> drivers/media/cec/i2c/ch7322.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
> index 34fad7123704..3c6e6496a001 100644
> --- a/drivers/media/cec/i2c/ch7322.c
> +++ b/drivers/media/cec/i2c/ch7322.c
> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
> static struct i2c_driver ch7322_i2c_driver = {
> .driver = {
> .name = "ch7322",
> - .of_match_table = of_match_ptr(ch7322_of_match),
> + .of_match_table = ch7322_of_match,
> },
> .probe_new = ch7322_probe,
> .remove = ch7322_remove,
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-08 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 21:47 [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr Guenter Roeck
2023-02-16 17:22 ` Joe Tessler
2023-03-08 18:21 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®