From: Bumwoo Lee <bw365.lee@samsung.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org
Cc: Bumwoo Lee <bw365.lee@samsung.com>
Subject: [PATCH 1/4] extcon: remove redundant null checking for class
Date: Fri, 17 Feb 2023 17:46:10 +0900 [thread overview]
Message-ID: <20230217084613.25359-2-bw365.lee@samsung.com> (raw)
In-Reply-To: <20230217084613.25359-1-bw365.lee@samsung.com>
Create_extcon_class() is already Null checking.
Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
---
drivers/extcon/extcon.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index e1c71359b605..adcf01132f70 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);
static int create_extcon_class(void)
{
- if (!extcon_class) {
- extcon_class = class_create(THIS_MODULE, "extcon");
- if (IS_ERR(extcon_class))
- return PTR_ERR(extcon_class);
- extcon_class->dev_groups = extcon_groups;
- }
+ if (extcon_class)
+ return 0;
+
+ extcon_class = class_create(THIS_MODULE, "extcon");
+ if (IS_ERR(extcon_class))
+ return PTR_ERR(extcon_class);
+ extcon_class->dev_groups = extcon_groups;
return 0;
}
@@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev)
int ret, index = 0;
static atomic_t edev_no = ATOMIC_INIT(-1);
- if (!extcon_class) {
- ret = create_extcon_class();
- if (ret < 0)
- return ret;
- }
+ ret = create_extcon_class();
+ if (ret < 0)
+ return ret;
if (!edev || !edev->supported_cable)
return -EINVAL;
--
2.35.1
next prev parent reply other threads:[~2023-02-17 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230217084732epcas1p29956bd24132b13b21923afd2563bf3dd@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 0/4] simplify extcon_dev_register function Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p12b708d8119263cef2233d652062ba3d1@epcas1p1.samsung.com>
2023-02-17 8:46 ` Bumwoo Lee [this message]
[not found] ` <CGME20230217084803epcas1p29ef858c842b18de89f1b034acb26086a@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 3/4] extcon: added extcon_alloc_muex " Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p17f034701f5bf98ef2650f2ec27cd2d35@epcas1p1.samsung.com>
2023-02-17 8:46 ` [PATCH 4/4] extcon: added extcon_alloc_groups " Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f@epcms1p6>
2023-02-20 4:36 ` [PATCH 3/4] extcon: added extcon_alloc_muex " MyungJoo Ham
[not found] ` <CGME20230217084803epcas1p29ef858c842b18de89f1b034acb26086a@epcms1p7>
2023-02-20 4:38 ` [PATCH 2/4] extcon: added extcon_alloc_cables " MyungJoo Ham
2023-02-20 4:57 ` Bumwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217084613.25359-2-bw365.lee@samsung.com \
--to=bw365.lee@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®