From: Bumwoo Lee <bw365.lee@samsung.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org
Cc: Bumwoo Lee <bw365.lee@samsung.com>
Subject: [PATCH 4/4] extcon: added extcon_alloc_groups to simplify extcon register function
Date: Fri, 17 Feb 2023 17:46:13 +0900 [thread overview]
Message-ID: <20230217084613.25359-5-bw365.lee@samsung.com> (raw)
In-Reply-To: <20230217084613.25359-1-bw365.lee@samsung.com>
The alloc groups is functionalized from extcon_dev_register.
Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
---
drivers/extcon/extcon.c | 57 +++++++++++++++++++++++++----------------
1 file changed, 35 insertions(+), 22 deletions(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 93cab4fe178e..9336d0d7589a 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1179,6 +1179,39 @@ static int extcon_alloc_muex(struct extcon_dev *edev)
return 0;
}
+/**
+ * extcon_alloc_groups() - alloc the groups for extcon device
+ * @edev: extcon device
+ *
+ * Returns 0 if success or error number if fail.
+ */
+static int extcon_alloc_groups(struct extcon_dev *edev)
+{
+ int index;
+
+ if (!edev->max_supported)
+ return 0;
+
+ edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2,
+ sizeof(struct attribute_group *),
+ GFP_KERNEL);
+ if (!edev->extcon_dev_type.groups)
+ return -ENOMEM;
+
+ edev->extcon_dev_type.name = dev_name(&edev->dev);
+ edev->extcon_dev_type.release = dummy_sysfs_dev_release;
+
+ for (index = 0; index < edev->max_supported; index++)
+ edev->extcon_dev_type.groups[index] = &edev->cables[index].attr_g;
+
+ if (edev->mutually_exclusive)
+ edev->extcon_dev_type.groups[index] = &edev->attr_g_muex;
+
+ edev->dev.type = &edev->extcon_dev_type;
+
+ return 0;
+}
+
/**
* extcon_dev_register() - Register an new extcon device
* @edev: the extcon device to be registered
@@ -1232,28 +1265,8 @@ int extcon_dev_register(struct extcon_dev *edev)
if (extcon_alloc_muex(edev))
goto err_alloc_muex;
- if (edev->max_supported) {
- edev->extcon_dev_type.groups =
- kcalloc(edev->max_supported + 2,
- sizeof(struct attribute_group *),
- GFP_KERNEL);
- if (!edev->extcon_dev_type.groups) {
- ret = -ENOMEM;
- goto err_alloc_groups;
- }
-
- edev->extcon_dev_type.name = dev_name(&edev->dev);
- edev->extcon_dev_type.release = dummy_sysfs_dev_release;
-
- for (index = 0; index < edev->max_supported; index++)
- edev->extcon_dev_type.groups[index] =
- &edev->cables[index].attr_g;
- if (edev->mutually_exclusive)
- edev->extcon_dev_type.groups[index] =
- &edev->attr_g_muex;
-
- edev->dev.type = &edev->extcon_dev_type;
- }
+ if (extcon_alloc_groups(edev))
+ goto err_alloc_groups;
spin_lock_init(&edev->lock);
if (edev->max_supported) {
--
2.35.1
next prev parent reply other threads:[~2023-02-17 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230217084732epcas1p29956bd24132b13b21923afd2563bf3dd@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 0/4] simplify extcon_dev_register function Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p12b708d8119263cef2233d652062ba3d1@epcas1p1.samsung.com>
2023-02-17 8:46 ` [PATCH 1/4] extcon: remove redundant null checking for class Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p29ef858c842b18de89f1b034acb26086a@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 3/4] extcon: added extcon_alloc_muex " Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p17f034701f5bf98ef2650f2ec27cd2d35@epcas1p1.samsung.com>
2023-02-17 8:46 ` Bumwoo Lee [this message]
[not found] ` <CGME20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f@epcms1p6>
2023-02-20 4:36 ` MyungJoo Ham
[not found] ` <CGME20230217084803epcas1p29ef858c842b18de89f1b034acb26086a@epcms1p7>
2023-02-20 4:38 ` [PATCH 2/4] extcon: added extcon_alloc_cables " MyungJoo Ham
2023-02-20 4:57 ` Bumwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217084613.25359-5-bw365.lee@samsung.com \
--to=bw365.lee@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®