From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Bumwoo Lee <bw365.lee@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function
Date: Mon, 20 Feb 2023 13:38:33 +0900 [thread overview]
Message-ID: <20230220043833epcms1p77e8ebcbb3882f5ad13ecac138db19ee2@epcms1p7> (raw)
In-Reply-To: <20230217084613.25359-3-bw365.lee@samsung.com>
>--------- Original Message ---------
>Sender : 이범우 <bw365.lee@samsung.com>Product S/W Lab(VD)/삼성전자
>Date : 2023-02-17 17:48 (GMT+9)
>Title : [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function
>
>The cable allocation part is functionalized from extcon_dev_register.
>
>Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
...
>+ if (extcon_alloc_cables(edev))
>+ goto err_alloc_cables;
>
You are abandoning error return values, here.
Please return appropriate error codes.
Cheers,
MyungJoo
next prev parent reply other threads:[~2023-02-20 4:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230217084732epcas1p29956bd24132b13b21923afd2563bf3dd@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 0/4] simplify extcon_dev_register function Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p12b708d8119263cef2233d652062ba3d1@epcas1p1.samsung.com>
2023-02-17 8:46 ` [PATCH 1/4] extcon: remove redundant null checking for class Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p29ef858c842b18de89f1b034acb26086a@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f@epcas1p2.samsung.com>
2023-02-17 8:46 ` [PATCH 3/4] extcon: added extcon_alloc_muex " Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p17f034701f5bf98ef2650f2ec27cd2d35@epcas1p1.samsung.com>
2023-02-17 8:46 ` [PATCH 4/4] extcon: added extcon_alloc_groups " Bumwoo Lee
[not found] ` <CGME20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f@epcms1p6>
2023-02-20 4:36 ` [PATCH 3/4] extcon: added extcon_alloc_muex " MyungJoo Ham
[not found] ` <CGME20230217084803epcas1p29ef858c842b18de89f1b034acb26086a@epcms1p7>
2023-02-20 4:38 ` MyungJoo Ham [this message]
2023-02-20 4:57 ` [PATCH 2/4] extcon: added extcon_alloc_cables " Bumwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220043833epcms1p77e8ebcbb3882f5ad13ecac138db19ee2@epcms1p7 \
--to=myungjoo.ham@samsung.com \
--cc=bw365.lee@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®