* [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards
@ 2023-02-21 10:26 Keguang Zhang
2023-02-21 10:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Keguang Zhang @ 2023-02-21 10:26 UTC (permalink / raw)
To: linux-mips, devicetree, linux-kernel
Cc: Thomas Bogendoerfer, Rob Herring, Krzysztof Kozlowski,
Jiaxun Yang, Keguang Zhang
Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
V1 -> V2: Add the according vendor prefix
Change the board string to enum
Modify the board description
---
.../devicetree/bindings/mips/loongson/devices.yaml | 12 ++++++++++++
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
2 files changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
index f13ce386f42c..15a43ce51bbf 100644
--- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
+++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
@@ -37,6 +37,18 @@ properties:
items:
- const: loongson,loongson64v-4core-virtio
+ - description: LS1B based boards
+ items:
+ - enum:
+ - loongson,lsgz-1b-dev
+ - const: loongson,ls1b
+
+ - description: LS1C based boards
+ items:
+ - enum:
+ - loongsonclub,smartloong-1c
+ - const: loongson,ls1c
+
additionalProperties: true
...
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 0e57ae744199..47565ebae4d1 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -757,6 +757,8 @@ patternProperties:
description: Lontium Semiconductor Corporation
"^loongson,.*":
description: Loongson Technology Corporation Limited
+ "^loongsonclub,.*":
+ description: Loongson Club
"^lsi,.*":
description: LSI Corp. (LSI Logic)
"^lwn,.*":
base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards
2023-02-21 10:26 [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards Keguang Zhang
@ 2023-02-21 10:36 ` Krzysztof Kozlowski
2023-02-21 10:50 ` Kelvin Cheung
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-21 10:36 UTC (permalink / raw)
To: Keguang Zhang, linux-mips, devicetree, linux-kernel
Cc: Thomas Bogendoerfer, Rob Herring, Krzysztof Kozlowski, Jiaxun Yang
On 21/02/2023 11:26, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V1 -> V2: Add the according vendor prefix
> Change the board string to enum
> Modify the board description
Thank you for your patch. There is something to discuss/improve.
> ---
> .../devicetree/bindings/mips/loongson/devices.yaml | 12 ++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..15a43ce51bbf 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,18 @@ properties:
> items:
> - const: loongson,loongson64v-4core-virtio
>
> + - description: LS1B based boards
> + items:
> + - enum:
> + - loongson,lsgz-1b-dev
> + - const: loongson,ls1b
> +
> + - description: LS1C based boards
> + items:
> + - enum:
> + - loongsonclub,smartloong-1c
> + - const: loongson,ls1c
> +
> additionalProperties: true
>
> ...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 0e57ae744199..47565ebae4d1 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -757,6 +757,8 @@ patternProperties:
> description: Lontium Semiconductor Corporation
> "^loongson,.*":
> description: Loongson Technology Corporation Limited
> + "^loongsonclub,.*":
> + description: Loongson Club
Are you sure that this is a board manufacturer?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards
2023-02-21 10:36 ` Krzysztof Kozlowski
@ 2023-02-21 10:50 ` Kelvin Cheung
0 siblings, 0 replies; 3+ messages in thread
From: Kelvin Cheung @ 2023-02-21 10:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-mips, devicetree, linux-kernel, Thomas Bogendoerfer,
Rob Herring, Krzysztof Kozlowski, Jiaxun Yang
On Tue, Feb 21, 2023 at 6:36 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 21/02/2023 11:26, Keguang Zhang wrote:
> > Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
> >
> > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> > ---
> > V1 -> V2: Add the according vendor prefix
> > Change the board string to enum
> > Modify the board description
>
> Thank you for your patch. There is something to discuss/improve.
>
> > ---
> > .../devicetree/bindings/mips/loongson/devices.yaml | 12 ++++++++++++
> > .../devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > index f13ce386f42c..15a43ce51bbf 100644
> > --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > @@ -37,6 +37,18 @@ properties:
> > items:
> > - const: loongson,loongson64v-4core-virtio
> >
> > + - description: LS1B based boards
> > + items:
> > + - enum:
> > + - loongson,lsgz-1b-dev
> > + - const: loongson,ls1b
> > +
> > + - description: LS1C based boards
> > + items:
> > + - enum:
> > + - loongsonclub,smartloong-1c
> > + - const: loongson,ls1c
> > +
> > additionalProperties: true
> >
> > ...
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 0e57ae744199..47565ebae4d1 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -757,6 +757,8 @@ patternProperties:
> > description: Lontium Semiconductor Corporation
> > "^loongson,.*":
> > description: Loongson Technology Corporation Limited
> > + "^loongsonclub,.*":
> > + description: Loongson Club
>
> Are you sure that this is a board manufacturer?
>
Sorry, that's inaccurate.
Let me update the manufacturer later.
> Best regards,
> Krzysztof
>
--
Best regards,
Kelvin Cheung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-21 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 10:26 [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards Keguang Zhang
2023-02-21 10:36 ` Krzysztof Kozlowski
2023-02-21 10:50 ` Kelvin Cheung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®