From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
Cc: Andrea Parri <parri.andrea@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Jonas Oberhauser <jonas.oberhauser@huawei.com>,
will@kernel.org, peterz@infradead.org, boqun.feng@gmail.com,
npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk,
luc.maranget@inria.fr, akiyks@gmail.com, dlustig@nvidia.com,
joel@joelfernandes.org, urezki@gmail.com,
quic_neeraju@quicinc.com, frederic@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tools/memory-model: Make ppo a subrelation of po
Date: Mon, 27 Feb 2023 14:21:20 -0800 [thread overview]
Message-ID: <20230227222120.GI2948950@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <bf2881fb-039b-06ab-68f9-806b29a84188@huaweicloud.com>
On Mon, Feb 27, 2023 at 09:13:01PM +0100, Jonas Oberhauser wrote:
>
>
> On 2/27/2023 8:40 PM, Andrea Parri wrote:
> > > The LKMM doesn't believe that a control or data dependency orders a
> > > plain write after a marked read. Hence in this test it thinks that P1's
> > > store to u0 can happen before the load of x1. I don't remember why we
> > > did it this way -- probably we just wanted to minimize the restrictions
> > > on when plain accesses can execute. (I do remember the reason for
> > > making address dependencies induce order; it was so RCU would work.)
> > >
> > > The patch below will change what the LKMM believes. It eliminates the
> > > positive outcome of the litmus test and the data race. Should it be
> > > adopted into the memory model?
> > (Unpopular opinion I know,) it should drop dependencies ordering, not
> > add/promote it.
> >
> > Andrea
>
> Maybe not as unpopular as you think... :)
> But either way IMHO it should be consistent; either take all the
> dependencies that are true and add them, or drop them all.
> In the latter case, RCU should change to an acquire barrier. (also, one
> would have to deal with OOTA in some yet different way).
>
> Generally my position is that unless there's a real-world benchmark with
> proven performance benefits of relying on dependency ordering, one should
> use an acquire barrier. I haven't yet met such a case, but maybe one of you
> has...
https://www.msully.net/thesis/thesis.pdf page 128 (PDF page 141).
Though this is admittedly for ARMv7 and PowerPC.
Thanx, Paul
next prev parent reply other threads:[~2023-02-27 22:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 13:52 Jonas Oberhauser
2023-02-24 15:32 ` Alan Stern
2023-02-24 18:37 ` Paul E. McKenney
2023-02-26 1:01 ` Paul E. McKenney
2023-02-26 2:29 ` Alan Stern
2023-02-26 3:03 ` Paul E. McKenney
2023-02-26 18:49 ` Paul E. McKenney
2023-02-26 3:09 ` Boqun Feng
2023-02-26 3:30 ` Alan Stern
2023-02-26 11:17 ` Jonas Oberhauser
2023-02-26 16:51 ` Alan Stern
2023-02-26 18:45 ` Paul E. McKenney
2023-02-26 19:32 ` Alan Stern
2023-02-27 14:03 ` Jonas Oberhauser
2023-02-27 16:16 ` Alan Stern
2023-02-27 16:50 ` Jonas Oberhauser
2023-02-27 18:41 ` Alan Stern
2023-02-27 19:40 ` Andrea Parri
2023-02-27 20:13 ` Jonas Oberhauser
2023-02-27 22:21 ` Paul E. McKenney [this message]
2023-02-28 8:49 ` Jonas Oberhauser
2023-02-28 15:40 ` Paul E. McKenney
2023-03-01 10:52 ` Jonas Oberhauser
2023-03-02 1:42 ` Paul E. McKenney
2023-02-26 2:58 ` Paul E. McKenney
2023-02-26 16:23 ` Joel Fernandes
2023-02-27 14:39 ` Jonas Oberhauser
2023-02-27 17:57 ` Joel Fernandes
2023-02-27 20:24 ` Jonas Oberhauser
2023-02-27 19:35 ` Andrea Parri
2023-02-28 22:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227222120.GI2948950@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=frederic@kernel.org \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=jonas.oberhauser@huawei.com \
--cc=jonas.oberhauser@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=stern@rowland.harvard.edu \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®