[PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used

[PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used

[Andy Shevchenko]

of_gpio.h in this driver is solely used as a proxy to other headers.
This is incorrect usage of the of_gpio.h. Replace it .h with what
indeed is used in the code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/regulator/s5m8767.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index 3122ca7de8f5..b4a699701a81 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -4,9 +4,10 @@
 //              http://www.samsung.com
 
 #include <linux/err.h>
-#include <linux/of_gpio.h>
+#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
-- 
2.39.2

Re: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote:
> of_gpio.h in this driver is solely used as a proxy to other headers.
> This is incorrect usage of the of_gpio.h. Replace it .h with what
> indeed is used in the code.

This breaks an x86 allmodconfig build:

/build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’:
/build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration]
  492 |                 gpio = of_get_named_gpio(pmic_np,
      |                        ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used

[Andy Shevchenko]

On Thu, Mar 16, 2023 at 01:10:46PM +0000, Mark Brown wrote:
> On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote:
> > of_gpio.h in this driver is solely used as a proxy to other headers.
> > This is incorrect usage of the of_gpio.h. Replace it .h with what
> > indeed is used in the code.
> 
> This breaks an x86 allmodconfig build:
> 
> /build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’:
> /build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration]
>   492 |                 gpio = of_get_named_gpio(pmic_np,
>       |                        ^~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Oh, sorry for that. I missed something.
Please, ignore this one, it should be different one.

-- 
With Best Regards,
Andy Shevchenko