From: Francois Romieu <romieu@fr.zoreil.com>
To: David Yang <mmyangfl@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: hisi-festa: Add support for HiSilicon Festa PHYs
Date: Fri, 17 Mar 2023 17:28:35 +0100 [thread overview]
Message-ID: <20230317162835.GA81256@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <d5ec2ec2-65a0-6ad3-a0a3-cad57d7f6616@gmail.com>
Heiner Kallweit <hkallweit1@gmail.com> :
> On 17.03.2023 15:30, David Yang wrote:
[...]
> > diff --git a/drivers/net/phy/hisi-festa.c b/drivers/net/phy/hisi-festa.c
> > new file mode 100644
> > index 000000000..ab54ed3ca
> > --- /dev/null
> > +++ b/drivers/net/phy/hisi-festa.c
[...]
> > +static int hisi_festa_patch_fw(struct phy_device *phydev)
This function can fail...
[...]
> > +static int hisi_festa_config_init(struct phy_device *phydev)
> > +{
> > + hisi_festa_patch_fw(phydev);
> > + /* ok, use programmed firmware */
> > + return 0;
... but nobody cares.
This lack of consistency may also be fixed once Heiner's remarks are
answered.
--
Ueimor
prev parent reply other threads:[~2023-03-17 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 14:30 David Yang
2023-03-17 14:59 ` Heiner Kallweit
2023-03-17 15:29 ` Yangfl
2023-03-17 16:28 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317162835.GA81256@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®