mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-hyperv@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel@lists.xenproject.org, Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v5 00/15] x86/mtrr: fix handling with PAT but without MTRR
Date: Sat,  1 Apr 2023 08:36:37 +0200	[thread overview]
Message-ID: <20230401063652.23522-1-jgross@suse.com> (raw)

This series tries to fix the rather special case of PAT being available
without having MTRRs (either due to CONFIG_MTRR being not set, or
because the feature has been disabled e.g. by a hypervisor).

The main use cases are Xen PV guests and SEV-SNP guests running under
Hyper-V.

Instead of trying to work around all the issues by adding if statements
here and there, just try to use the complete available infrastructure
by setting up a read-only MTRR state when needed.

In the Xen PV case the current MTRR MSR values can be read from the
hypervisor, while for the SEV-SNP case all needed is to set the
default caching mode to "WB".

I have added more cleanup which has been discussed when looking into
the most recent failures.

Note that I couldn't test the Hyper-V related change (patch 3).

Running on bare metal and with Xen didn't show any problems with the
series applied.

It should be noted that patches 9+10 are replacing today's way to
lookup the MTRR cache type for a memory region from looking at the
MTRR register values to building a memory map with the cache types.
This should make the lookup much faster and much easier to understand.

Changes in V2:
- replaced former patches 1+2 with new patches 1-4, avoiding especially
  the rather hacky approach of V1, while making all the MTRR type
  conflict tests available for the Xen PV case
- updated patch 6 (was patch 4 in V1)

Changes in V3:
- dropped patch 5 of V2, as already applied
- split patch 1 of V2 into 2 patches
- new patches 6-10
- addressed comments

Changes in V4:
- addressed comments

Changes in V5
- addressed comments
- some other small fixes
- new patches 3, 8 and 15

clone of "mtrr"

Juergen Gross (15):
  x86/mtrr: split off physical address size calculation
  x86/mtrr: optimize mtrr_calc_physbits()
  x86/mtrr: replace some constants with defines
  x86/mtrr: support setting MTRR state for software defined MTRRs
  x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest
  x86/xen: set MTRR state when running as Xen PV initial domain
  x86/mtrr: replace vendor tests in MTRR code
  x86/mtrr: have only one set_mtrr() variant
  x86/mtrr: allocate mtrr_value array dynamically
  x86/mtrr: add get_effective_type() service function
  x86/mtrr: construct a memory map with cache modes
  x86/mtrr: use new cache_map in mtrr_type_lookup()
  x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID
  x86/mm: only check uniform after calling mtrr_type_lookup()
  x86/mtrr: remove unused code

 arch/x86/include/asm/mtrr.h        |  44 ++-
 arch/x86/include/uapi/asm/mtrr.h   |   6 +-
 arch/x86/kernel/cpu/mshyperv.c     |   4 +
 arch/x86/kernel/cpu/mtrr/amd.c     |   2 +-
 arch/x86/kernel/cpu/mtrr/centaur.c |  11 +-
 arch/x86/kernel/cpu/mtrr/cleanup.c |   6 +-
 arch/x86/kernel/cpu/mtrr/cyrix.c   |   2 +-
 arch/x86/kernel/cpu/mtrr/generic.c | 578 +++++++++++++++++++----------
 arch/x86/kernel/cpu/mtrr/mtrr.c    | 146 ++++----
 arch/x86/kernel/cpu/mtrr/mtrr.h    |   7 +-
 arch/x86/kernel/setup.c            |   2 +
 arch/x86/mm/pgtable.c              |  24 +-
 arch/x86/xen/enlighten_pv.c        |  52 +++
 13 files changed, 573 insertions(+), 311 deletions(-)

-- 
2.35.3


             reply	other threads:[~2023-04-01  6:37 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01  6:36 Juergen Gross [this message]
2023-04-01  6:36 ` [PATCH v5 01/15] x86/mtrr: split off physical address size calculation Juergen Gross
2023-04-01  6:36 ` [PATCH v5 02/15] x86/mtrr: optimize mtrr_calc_physbits() Juergen Gross
2023-04-01  6:36 ` [PATCH v5 03/15] x86/mtrr: replace some constants with defines Juergen Gross
2023-04-03 16:03   ` Borislav Petkov
2023-04-05  7:55     ` Juergen Gross
2023-04-05 20:26       ` Borislav Petkov
2023-04-11 13:32         ` Juergen Gross
2023-04-01  6:36 ` [PATCH v5 04/15] x86/mtrr: support setting MTRR state for software defined MTRRs Juergen Gross
2023-04-03  2:25   ` Huang, Kai
2023-04-03  7:10     ` Juergen Gross
2023-04-03  9:27       ` Huang, Kai
2023-04-03  9:35         ` Juergen Gross
2023-04-03  9:44           ` Huang, Kai
2023-04-03  9:43         ` Huang, Kai
2023-04-11 13:20   ` Borislav Petkov
2023-04-11 13:31     ` Juergen Gross
2023-04-11 17:14       ` Borislav Petkov
2023-04-11 13:59     ` Michael Kelley (LINUX)
2023-04-11 14:04       ` Juergen Gross
2023-04-11 14:26         ` Borislav Petkov
2023-04-11 15:57           ` Juergen Gross
2023-04-11 17:15             ` Borislav Petkov
2023-04-12  8:30               ` Juergen Gross
2023-04-11 14:25       ` Borislav Petkov
2023-04-01  6:36 ` [PATCH v5 05/15] x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest Juergen Gross
2023-04-02  2:36   ` Michael Kelley (LINUX)
2023-04-01  6:36 ` [PATCH v5 06/15] x86/xen: set MTRR state when running as Xen PV initial domain Juergen Gross
2023-04-01  6:36 ` [PATCH v5 07/15] x86/mtrr: replace vendor tests in MTRR code Juergen Gross
2023-04-12  8:45   ` Borislav Petkov
2023-04-12 10:25     ` Juergen Gross
2023-04-01  6:36 ` [PATCH v5 08/15] x86/mtrr: have only one set_mtrr() variant Juergen Gross
2023-04-12 12:30   ` Borislav Petkov
2023-04-12 12:56     ` Juergen Gross
2023-04-12 20:09       ` Borislav Petkov
2023-04-01  6:36 ` [PATCH v5 09/15] x86/mtrr: allocate mtrr_value array dynamically Juergen Gross
2023-04-12 21:11   ` Borislav Petkov
2023-04-13 10:07     ` Juergen Gross
2023-04-01  6:36 ` [PATCH v5 10/15] x86/mtrr: add get_effective_type() service function Juergen Gross
2023-04-01  6:36 ` [PATCH v5 11/15] x86/mtrr: construct a memory map with cache modes Juergen Gross
2023-04-20 12:15   ` Borislav Petkov
2023-04-20 12:30     ` Juergen Gross
2023-04-20 12:30       ` Juergen Gross
2023-04-20 13:01       ` Borislav Petkov
2023-04-20 13:57         ` Juergen Gross
2023-04-20 14:54           ` Borislav Petkov
2023-04-20 15:10             ` Juergen Gross
2023-04-21 11:23               ` Borislav Petkov
2023-04-21 14:35                 ` Juergen Gross
2023-04-01  6:36 ` [PATCH v5 12/15] x86/mtrr: use new cache_map in mtrr_type_lookup() Juergen Gross
2023-04-01  6:36 ` [PATCH v5 13/15] x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID Juergen Gross
2023-04-01  6:36 ` [PATCH v5 14/15] x86/mm: only check uniform after calling mtrr_type_lookup() Juergen Gross
2023-04-01  6:36 ` [PATCH v5 15/15] x86/mtrr: remove unused code Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230401063652.23522-1-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®