* [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static
@ 2023-04-04 16:36 Tom Rix
2023-04-04 19:09 ` Michael Walle
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2023-04-04 16:36 UTC (permalink / raw)
To: michael, srinivas.kandagatla; +Cc: linux-kernel, Tom Rix
smatch reports
drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
'sl28vpd_layout' was not declared. Should it be static?
This variable is only used in one file so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/nvmem/layouts/sl28vpd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/layouts/sl28vpd.c b/drivers/nvmem/layouts/sl28vpd.c
index 9cc1715c2fd5..05671371f631 100644
--- a/drivers/nvmem/layouts/sl28vpd.c
+++ b/drivers/nvmem/layouts/sl28vpd.c
@@ -141,7 +141,7 @@ static const struct of_device_id sl28vpd_of_match_table[] = {
};
MODULE_DEVICE_TABLE(of, sl28vpd_of_match_table);
-struct nvmem_layout sl28vpd_layout = {
+static struct nvmem_layout sl28vpd_layout = {
.name = "sl28-vpd",
.of_match_table = sl28vpd_of_match_table,
.add_cells = sl28vpd_add_cells,
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static
2023-04-04 16:36 [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static Tom Rix
@ 2023-04-04 19:09 ` Michael Walle
2023-04-05 12:25 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Michael Walle @ 2023-04-04 19:09 UTC (permalink / raw)
To: Tom Rix; +Cc: srinivas.kandagatla, linux-kernel
Am 2023-04-04 18:36, schrieb Tom Rix:
> smatch reports
> drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
> 'sl28vpd_layout' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Fixes tag?
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static
2023-04-04 19:09 ` Michael Walle
@ 2023-04-05 12:25 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2023-04-05 12:25 UTC (permalink / raw)
To: Michael Walle; +Cc: srinivas.kandagatla, linux-kernel
On 4/4/23 12:09 PM, Michael Walle wrote:
> Am 2023-04-04 18:36, schrieb Tom Rix:
>> smatch reports
>> drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
>> 'sl28vpd_layout' was not declared. Should it be static?
>>
>> This variable is only used in one file so it should be static.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Fixes tag?
>
I am cleaning all of the similar reports by smatch, there is a couple
hundred.
Because the code works as-is, I do not consider them broken and needing
fixes tags.
However I do not mind adding then if they are required.
Tom
> Reviewed-by: Michael Walle <michael@walle.cc>
>
> -michael
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-05 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-04 16:36 [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static Tom Rix
2023-04-04 19:09 ` Michael Walle
2023-04-05 12:25 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®