mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor.dooley@microchip.com>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: <linux-kernel@vger.kernel.org>, Radu Rendec <rrendec@redhat.com>,
	Alexandre Ghiti <alexghiti@rivosinc.com>,
	Will Deacon <will@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Palmer Dabbelt <palmer@rivosinc.com>,
	Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v3 2/4] cacheinfo: Check cache properties are present in DT
Date: Thu, 13 Apr 2023 11:06:08 +0100	[thread overview]
Message-ID: <20230413-dimness-shove-5ecd9d69bfff@wendy> (raw)
In-Reply-To: <20230413091436.230134-3-pierre.gondois@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On Thu, Apr 13, 2023 at 11:14:32AM +0200, Pierre Gondois wrote:
> If a Device Tree (DT) is used, the presence of cache properties is
> assumed. Not finding any is not considered. For arm64 platforms,
> cache information can be fetched from the clidr_el1 register.
> Checking whether cache information is available in the DT
> allows to switch to using clidr_el1.
> 
> init_of_cache_level()
> \-of_count_cache_leaves()
> will assume there a 2 cache leaves (L1 data/instruction caches), which
> can be different from clidr_el1 information.
> 
> cache_setup_of_node() tries to read cache properties in the DT.
> If there are none, this is considered a success. Knowing no
> information was available would allow to switch to using clidr_el1.
> 
> Fixes: de0df442ee49 ("cacheinfo: Check 'cache-unified' property to count cache leaves")
> Reported-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>


Since there's no longer an error printed
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for the update Pierre,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-04-13 10:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  9:14 [PATCH v3 0/4] cacheinfo: Correctly fallback to using clidr_el1's information Pierre Gondois
2023-04-13  9:14 ` [PATCH v3 1/4] cacheinfo: Check sib_leaf in cache_leaves_are_shared() Pierre Gondois
2023-04-13 10:04   ` Conor Dooley
2023-04-13  9:14 ` [PATCH v3 2/4] cacheinfo: Check cache properties are present in DT Pierre Gondois
2023-04-13 10:06   ` Conor Dooley [this message]
2023-04-13 18:16   ` Florian Fainelli
2023-04-13 19:50     ` Sudeep Holla
2023-04-13 20:06       ` Florian Fainelli
2023-04-14  7:33         ` Pierre Gondois
2023-04-14  9:05         ` Sudeep Holla
2023-04-14 22:21           ` Florian Fainelli
2023-04-14  8:19     ` Pierre Gondois
2023-04-13  9:14 ` [PATCH v3 3/4] arch_topology: Remove early cacheinfo error message Pierre Gondois
2023-04-13 10:02   ` Conor Dooley
2023-04-13 10:25     ` Conor Dooley
2023-04-13 15:25     ` Pierre Gondois
2023-04-13 16:23       ` Conor Dooley
2023-04-13  9:14 ` [PATCH v3 4/4] cacheinfo: Add use_arch[|_cache]_info field/function Pierre Gondois
2023-04-13  9:49   ` Sudeep Holla
2023-04-13 10:17     ` Pierre Gondois
2023-04-13 10:20       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413-dimness-shove-5ecd9d69bfff@wendy \
    --to=conor.dooley@microchip.com \
    --cc=alexghiti@rivosinc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gshan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=palmer@rivosinc.com \
    --cc=pierre.gondois@arm.com \
    --cc=rafael@kernel.org \
    --cc=rrendec@redhat.com \
    --cc=sudeep.holla@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®