From: Conor Dooley <conor.dooley@microchip.com>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: <linux-kernel@vger.kernel.org>, Radu Rendec <rrendec@redhat.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Will Deacon <will@kernel.org>, Conor Dooley <conor@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v3 3/4] arch_topology: Remove early cacheinfo error message
Date: Thu, 13 Apr 2023 11:02:44 +0100 [thread overview]
Message-ID: <20230413-prudishly-unruly-090f5297fd54@wendy> (raw)
In-Reply-To: <20230413091436.230134-4-pierre.gondois@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]
On Thu, Apr 13, 2023 at 11:14:33AM +0200, Pierre Gondois wrote:
> fetch_cache_info() tries to get the number of cache leaves/levels
> for each CPU in order to pre-allocate memory for cacheinfo struct.
> Allocating this memory later triggers a:
> 'BUG: sleeping function called from invalid context'
> in PREEMPT_RT kernels.
>
> If there is no cache related information available in DT or ACPI,
> fetch_cache_info() fails and an error message is printed:
> 'Early cacheinfo failed, ret = ...'
>
> Not having cache information should be a valid configuration.
> Remove the error message if fetch_cache_info() fails.
>
> Suggested-by: Conor Dooley <conor@kernel.org>
Not that it really matters for suggested-by, and there's no way really
for you to know, but the corporate overlords prefer:
s/conor@kernel.org/conor.dooley@microchip.com/
> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> drivers/base/arch_topology.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index b1c1dd38ab01..1f071eaede5b 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -843,10 +843,8 @@ void __init init_cpu_topology(void)
>
> for_each_possible_cpu(cpu) {
> ret = fetch_cache_info(cpu);
> - if (ret) {
> - pr_err("Early cacheinfo failed, ret = %d\n", ret);
Hmm do you really want to remove the print altogether? This can fail
with -EINVAL and -ENOMEM too, so should we just check for
| if (ret && ret != -ENOENT)
instead, since in the other cases it really did fail?
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-13 10:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 9:14 [PATCH v3 0/4] cacheinfo: Correctly fallback to using clidr_el1's information Pierre Gondois
2023-04-13 9:14 ` [PATCH v3 1/4] cacheinfo: Check sib_leaf in cache_leaves_are_shared() Pierre Gondois
2023-04-13 10:04 ` Conor Dooley
2023-04-13 9:14 ` [PATCH v3 2/4] cacheinfo: Check cache properties are present in DT Pierre Gondois
2023-04-13 10:06 ` Conor Dooley
2023-04-13 18:16 ` Florian Fainelli
2023-04-13 19:50 ` Sudeep Holla
2023-04-13 20:06 ` Florian Fainelli
2023-04-14 7:33 ` Pierre Gondois
2023-04-14 9:05 ` Sudeep Holla
2023-04-14 22:21 ` Florian Fainelli
2023-04-14 8:19 ` Pierre Gondois
2023-04-13 9:14 ` [PATCH v3 3/4] arch_topology: Remove early cacheinfo error message Pierre Gondois
2023-04-13 10:02 ` Conor Dooley [this message]
2023-04-13 10:25 ` Conor Dooley
2023-04-13 15:25 ` Pierre Gondois
2023-04-13 16:23 ` Conor Dooley
2023-04-13 9:14 ` [PATCH v3 4/4] cacheinfo: Add use_arch[|_cache]_info field/function Pierre Gondois
2023-04-13 9:49 ` Sudeep Holla
2023-04-13 10:17 ` Pierre Gondois
2023-04-13 10:20 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413-prudishly-unruly-090f5297fd54@wendy \
--to=conor.dooley@microchip.com \
--cc=alexghiti@rivosinc.com \
--cc=conor@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=palmer@rivosinc.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=rrendec@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®