From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Tim Zimmermann <tim@linux4.de>
Subject: [PATCH v3 2/6] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace
Date: Thu, 13 Apr 2023 13:46:43 +0200 [thread overview]
Message-ID: <20230413114647.3878792-3-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230413114647.3878792-1-daniel.lezcano@linaro.org>
The pch_critical() callback accesses the thermal zone device structure
internals, it dereferences the thermal zone struct device and the 'type'.
Use the available accessors instead of accessing the structure directly.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/intel/intel_pch_thermal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index dce50d239357..b3905e34c507 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -127,7 +127,8 @@ static int pch_thermal_get_temp(struct thermal_zone_device *tzd, int *temp)
static void pch_critical(struct thermal_zone_device *tzd)
{
- dev_dbg(&tzd->device, "%s: critical temperature reached\n", tzd->type);
+ dev_dbg(thermal_zone_device(tzd), "%s: critical temperature reached\n",
+ thermal_zone_device_type(tzd));
}
static struct thermal_zone_device_ops tzd_ops = {
--
2.34.1
next prev parent reply other threads:[~2023-04-13 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 11:46 [PATCH v3 0/6] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 1/6] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-13 11:46 ` Daniel Lezcano [this message]
2023-04-13 11:46 ` [PATCH v3 3/6] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 4/6] thermal/drivers/menlow: " Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 5/6] thermal/drivers/acpi: Make cross dev link optional by configuration Daniel Lezcano
2023-04-18 13:38 ` Rafael J. Wysocki
2023-04-18 13:44 ` Daniel Lezcano
2023-04-18 13:47 ` Rafael J. Wysocki
2023-04-18 13:48 ` Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Daniel Lezcano
2023-04-18 13:46 ` Rafael J. Wysocki
2023-04-17 13:17 ` [PATCH v3 0/6] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-18 13:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413114647.3878792-3-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tim@linux4.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®