mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
	Sujith Thomas <sujith.thomas@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: [PATCH v3 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional
Date: Thu, 13 Apr 2023 13:46:47 +0200	[thread overview]
Message-ID: <20230413114647.3878792-7-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230413114647.3878792-1-daniel.lezcano@linaro.org>

The Menlon thermal driver creates specific files in the thermal zone
sysfs class. It is specific to Menlon and these entries look debug
code. It is probable these are not needed.

Let's make the code optional and disable it by default.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/intel/Kconfig        | 11 +++++++++++
 drivers/thermal/intel/intel_menlow.c |  3 +++
 2 files changed, 14 insertions(+)

diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
index cb7e7697cf1e..1405d9cd2bab 100644
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -112,6 +112,17 @@ config INTEL_MENLOW
 
 	  If unsure, say N.
 
+config INTEL_MENLOW_SYSFS_ADDON
+       bool "Enable thermal sysfs addon"
+       depends on INTEL_MENLOW
+       def_bool n
+       help
+	 Enable sysfs extra information added in the thermal
+	 zone. This is specific to this driver. By default those are
+	 disabled and are candidate for removal, if you need these
+	 information anyway, enable the option or upgrade the
+	 userspace program using them.
+
 config INTEL_HFI_THERMAL
 	bool "Intel Hardware Feedback Interface"
 	depends on NET
diff --git a/drivers/thermal/intel/intel_menlow.c b/drivers/thermal/intel/intel_menlow.c
index d720add918ff..a169d7e4f537 100644
--- a/drivers/thermal/intel/intel_menlow.c
+++ b/drivers/thermal/intel/intel_menlow.c
@@ -374,6 +374,9 @@ static int intel_menlow_add_one_attribute(char *name, umode_t mode, void *show,
 	struct intel_menlow_attribute *attr;
 	int result;
 
+	if (!IS_ENABLED(CONFIG_INTEL_MENLOW_SYSFS_ADDON))
+		return 0;
+	
 	attr = kzalloc(sizeof(struct intel_menlow_attribute), GFP_KERNEL);
 	if (!attr)
 		return -ENOMEM;
-- 
2.34.1


  parent reply	other threads:[~2023-04-13 11:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 11:46 [PATCH v3 0/6] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 1/6] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 2/6] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 3/6] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 4/6] thermal/drivers/menlow: " Daniel Lezcano
2023-04-13 11:46 ` [PATCH v3 5/6] thermal/drivers/acpi: Make cross dev link optional by configuration Daniel Lezcano
2023-04-18 13:38   ` Rafael J. Wysocki
2023-04-18 13:44     ` Daniel Lezcano
2023-04-18 13:47       ` Rafael J. Wysocki
2023-04-18 13:48         ` Daniel Lezcano
2023-04-13 11:46 ` Daniel Lezcano [this message]
2023-04-18 13:46   ` [PATCH v3 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Rafael J. Wysocki
2023-04-17 13:17 ` [PATCH v3 0/6] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-18 13:51   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413114647.3878792-7-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=amitk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®