From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
Sujith Thomas <sujith.thomas@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v4 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional
Date: Wed, 19 Apr 2023 10:33:43 +0200 [thread overview]
Message-ID: <20230419083343.505780-7-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230419083343.505780-1-daniel.lezcano@linaro.org>
The Menlon thermal driver creates auxiliary trip points in the thermal
zone sysfs directory. It is specific to Menlon. Actually these trip
points could be generalized with the generic trip points in the future.
Let's make the code optional and disable it by default so we have a
consistency with the attributes in the thermal zone sysfs
directories. If that hurts we will enable by default this option
instead of disabling it.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/intel/Kconfig | 11 +++++++++++
drivers/thermal/intel/intel_menlow.c | 9 +++++++++
2 files changed, 20 insertions(+)
diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
index cb7e7697cf1e..ef7ffe6b56a0 100644
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -112,6 +112,17 @@ config INTEL_MENLOW
If unsure, say N.
+config INTEL_MENLOW_SYSFS_ADDON
+ bool "Enable extra sysfs attributes in the thermal zone"
+ depends on INTEL_MENLOW
+ def_bool n
+ help
+ Create auxiliary trip points in the thermal zone sysfs
+ directory. This is specific to this driver. By default those
+ are disabled and are candidate for removal, if you need these
+ information anyway, enable the option or upgrade the
+ userspace program using them.
+
config INTEL_HFI_THERMAL
bool "Intel Hardware Feedback Interface"
depends on NET
diff --git a/drivers/thermal/intel/intel_menlow.c b/drivers/thermal/intel/intel_menlow.c
index d720add918ff..605983be516c 100644
--- a/drivers/thermal/intel/intel_menlow.c
+++ b/drivers/thermal/intel/intel_menlow.c
@@ -367,6 +367,7 @@ static ssize_t bios_enabled_show(struct device *dev,
return sprintf(buf, "%s\n", bios_enabled ? "enabled" : "disabled");
}
+#ifdef CONFIG_INTEL_MENLOW_SYSFS_ADDON
static int intel_menlow_add_one_attribute(char *name, umode_t mode, void *show,
void *store, struct device *dev,
acpi_handle handle)
@@ -398,6 +399,14 @@ static int intel_menlow_add_one_attribute(char *name, umode_t mode, void *show,
return 0;
}
+#else
+static int intel_menlow_add_one_attribute(char *name, umode_t mode, void *show,
+ void *store, struct device *dev,
+ acpi_handle handle)
+{
+ return 0;
+}
+#endif
static acpi_status intel_menlow_register_sensor(acpi_handle handle, u32 lvl,
void *context, void **rv)
--
2.34.1
next prev parent reply other threads:[~2023-04-19 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 8:33 [PATCH v4 0/6] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 1/6] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 2/6] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 3/6] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 4/6] thermal/drivers/menlow: " Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 5/6] thermal/drivers/acpi: Move to dedicated function sysfs extra attr creation Daniel Lezcano
2023-04-19 8:33 ` Daniel Lezcano [this message]
2023-04-20 17:24 ` [PATCH v4 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Rafael J. Wysocki
2023-04-20 21:40 ` Daniel Lezcano
2023-04-26 16:58 ` Rafael J. Wysocki
2023-04-27 17:23 ` [PATCH v4 0/6] Thermal zone device structure encapsulation Rafael J. Wysocki
2023-04-27 20:53 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419083343.505780-7-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome