From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
Sujith Thomas <sujith.thomas@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v4 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional
Date: Thu, 20 Apr 2023 23:40:03 +0200 [thread overview]
Message-ID: <bcc96406-3f74-b79b-3f75-0c3bd88c5eea@linaro.org> (raw)
In-Reply-To: <CAJZ5v0gi4j=kJBnXCotQ8_+t39CzOFSBie9Yc6x8BV=TYxsjPQ@mail.gmail.com>
On 20/04/2023 19:24, Rafael J. Wysocki wrote:
[ ... ]
> After looking at it once more, I think that this driver isn't really
> functional without the additional sysfs attributes, so if
> CONFIG_INTEL_MENLOW_SYSFS_ADDON is set, the driver effectively becomes
> dead code.
>
> That's rather unfortunate and I'm not sure how to deal with it ATM.
>
> I can queue up the rest of the series for 6.4-rc1 (in which case it
> will be pushed in the second half of the merge window), but this
> particular patch requires more thought IMV.
I'm fine if you drop this one from the series.
Thanks for looking at it more deeply
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-04-20 21:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 8:33 [PATCH v4 0/6] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 1/6] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 2/6] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 3/6] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 4/6] thermal/drivers/menlow: " Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 5/6] thermal/drivers/acpi: Move to dedicated function sysfs extra attr creation Daniel Lezcano
2023-04-19 8:33 ` [PATCH v4 6/6] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Daniel Lezcano
2023-04-20 17:24 ` Rafael J. Wysocki
2023-04-20 21:40 ` Daniel Lezcano [this message]
2023-04-26 16:58 ` Rafael J. Wysocki
2023-04-27 17:23 ` [PATCH v4 0/6] Thermal zone device structure encapsulation Rafael J. Wysocki
2023-04-27 20:53 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc96406-3f74-b79b-3f75-0c3bd88c5eea@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®