* [PATCH v2] crypto: engine - Fix struct crypto_engine_op doc
@ 2023-04-24 0:29 David Yang
2023-04-24 1:25 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: David Yang @ 2023-04-24 0:29 UTC (permalink / raw)
To: linux-crypto
Cc: David Yang, Randy Dunlap, Herbert Xu, David S. Miller, linux-kernel
Remove redundant underscore and fix some grammar in prepare_request doc.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/b58dc77c-c975-46cf-581c-368d9a87ae64@infradead.org
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
include/crypto/engine.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/crypto/engine.h b/include/crypto/engine.h
index ae133e98d813..2038764b30c2 100644
--- a/include/crypto/engine.h
+++ b/include/crypto/engine.h
@@ -78,7 +78,7 @@ struct crypto_engine {
/*
* struct crypto_engine_op - crypto hardware engine operations
- * @prepare__request: do some prepare if need before handle the current request
+ * @prepare_request: do some preparation if needed before handling the current request
* @unprepare_request: undo any work done by prepare_request()
* @do_one_request: do encryption for current request
*/
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] crypto: engine - Fix struct crypto_engine_op doc
2023-04-24 0:29 [PATCH v2] crypto: engine - Fix struct crypto_engine_op doc David Yang
@ 2023-04-24 1:25 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2023-04-24 1:25 UTC (permalink / raw)
To: David Yang, linux-crypto; +Cc: Herbert Xu, David S. Miller, linux-kernel
Hi,
On 4/23/23 17:29, David Yang wrote:
> Remove redundant underscore and fix some grammar in prepare_request doc.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
No, I didn't report this issue. You either found it on your own or someone/something
else reported it.
> Link: https://lore.kernel.org/r/b58dc77c-c975-46cf-581c-368d9a87ae64@infradead.org
Also drop the Link: line.
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> include/crypto/engine.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/crypto/engine.h b/include/crypto/engine.h
> index ae133e98d813..2038764b30c2 100644
> --- a/include/crypto/engine.h
> +++ b/include/crypto/engine.h
> @@ -78,7 +78,7 @@ struct crypto_engine {
>
> /*
> * struct crypto_engine_op - crypto hardware engine operations
> - * @prepare__request: do some prepare if need before handle the current request
> + * @prepare_request: do some preparation if needed before handling the current request
That part looks good.
> * @unprepare_request: undo any work done by prepare_request()
> * @do_one_request: do encryption for current request
> */
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-24 1:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 0:29 [PATCH v2] crypto: engine - Fix struct crypto_engine_op doc David Yang
2023-04-24 1:25 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®