From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Kever Yang <kever.yang@rock-chips.com>,
Finley Xiao <finley.xiao@rock-chips.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: [PATCH 4/8] nvmem: rockchip-otp: Generalize rockchip_otp_wait_status()
Date: Mon, 1 May 2023 11:43:56 +0300 [thread overview]
Message-ID: <20230501084401.765169-5-cristian.ciocaltea@collabora.com> (raw)
In-Reply-To: <20230501084401.765169-1-cristian.ciocaltea@collabora.com>
In preparation to support additional Rockchip OTP memory devices with
different register layout, generalize rockchip_otp_wait_status() to
accept a new parameter for specifying the offset of the status register.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
drivers/nvmem/rockchip-otp.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
index a5b234e60735..e308dd3b4eb1 100644
--- a/drivers/nvmem/rockchip-otp.c
+++ b/drivers/nvmem/rockchip-otp.c
@@ -90,18 +90,19 @@ static int rockchip_otp_reset(struct rockchip_otp *otp)
return 0;
}
-static int rockchip_otp_wait_status(struct rockchip_otp *otp, u32 flag)
+static int rockchip_otp_wait_status(struct rockchip_otp *otp,
+ unsigned int reg, u32 flag)
{
u32 status = 0;
int ret;
- ret = readl_poll_timeout_atomic(otp->base + OTPC_INT_STATUS, status,
+ ret = readl_poll_timeout_atomic(otp->base + reg, status,
(status & flag), 1, OTPC_TIMEOUT);
if (ret)
return ret;
/* clean int status */
- writel(flag, otp->base + OTPC_INT_STATUS);
+ writel(flag, otp->base + reg);
return 0;
}
@@ -123,7 +124,7 @@ static int rockchip_otp_ecc_enable(struct rockchip_otp *otp, bool enable)
writel(SBPI_ENABLE_MASK | SBPI_ENABLE, otp->base + OTPC_SBPI_CTRL);
- ret = rockchip_otp_wait_status(otp, OTPC_SBPI_DONE);
+ ret = rockchip_otp_wait_status(otp, OTPC_INT_STATUS, OTPC_SBPI_DONE);
if (ret < 0)
dev_err(otp->dev, "timeout during ecc_enable\n");
@@ -156,7 +157,7 @@ static int px30_otp_read(void *context, unsigned int offset,
otp->base + OTPC_USER_ADDR);
writel(OTPC_USER_FSM_ENABLE | OTPC_USER_FSM_ENABLE_MASK,
otp->base + OTPC_USER_ENABLE);
- ret = rockchip_otp_wait_status(otp, OTPC_USER_DONE);
+ ret = rockchip_otp_wait_status(otp, OTPC_INT_STATUS, OTPC_USER_DONE);
if (ret < 0) {
dev_err(otp->dev, "timeout during read setup\n");
goto read_end;
--
2.40.0
next prev parent reply other threads:[~2023-05-01 8:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 8:43 [PATCH 0/8] Add RK3588 OTP memory support Cristian Ciocaltea
2023-05-01 8:43 ` [PATCH 1/8] dt-bindings: nvmem: Convert rockchip-otp.txt to dt-schema Cristian Ciocaltea
2023-05-02 8:38 ` Heiko Stübner
2023-05-03 6:27 ` Krzysztof Kozlowski
2023-05-01 8:43 ` [PATCH 2/8] dt-bindings: nvmem: rockchip-otp: Add compatible for RK3588 Cristian Ciocaltea
2023-05-02 8:42 ` Heiko Stübner
2023-05-02 12:46 ` Cristian Ciocaltea
2023-05-03 6:28 ` Krzysztof Kozlowski
2023-05-04 14:14 ` Cristian Ciocaltea
2023-05-04 14:39 ` Krzysztof Kozlowski
2023-05-01 8:43 ` [PATCH 3/8] nvmem: rockchip-otp: Add clocks and reg_read to rockchip_data Cristian Ciocaltea
2023-05-02 8:47 ` Heiko Stübner
2023-05-02 12:49 ` Cristian Ciocaltea
2023-05-01 8:43 ` Cristian Ciocaltea [this message]
2023-05-02 8:48 ` [PATCH 4/8] nvmem: rockchip-otp: Generalize rockchip_otp_wait_status() Heiko Stübner
2023-05-01 8:43 ` [PATCH 5/8] nvmem: rockchip-otp: Use devm_reset_control_array_get_exclusive() Cristian Ciocaltea
2023-05-02 8:51 ` Heiko Stübner
2023-05-01 8:43 ` [PATCH 6/8] nvmem: rockchip-otp: Improve probe error handling Cristian Ciocaltea
2023-05-02 8:52 ` Heiko Stübner
2023-05-01 8:43 ` [PATCH 7/8] nvmem: rockchip-otp: Add support for RK3588 Cristian Ciocaltea
2023-05-02 8:55 ` Heiko Stübner
2023-05-01 8:44 ` [PATCH 8/8] arm64: dts: rockchip: Add rk3588 OTP node Cristian Ciocaltea
2023-05-02 8:57 ` Heiko Stübner
2023-05-02 8:26 ` [PATCH 0/8] Add RK3588 OTP memory support Vincent Legoll
2023-05-02 12:40 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501084401.765169-5-cristian.ciocaltea@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®