From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Kever Yang <kever.yang@rock-chips.com>,
Finley Xiao <finley.xiao@rock-chips.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 2/8] dt-bindings: nvmem: rockchip-otp: Add compatible for RK3588
Date: Thu, 4 May 2023 16:39:27 +0200 [thread overview]
Message-ID: <2490f7dd-9b6b-2865-4e44-37808b167c11@linaro.org> (raw)
In-Reply-To: <a5d4a5be-b658-d9fe-59b8-69199329446d@collabora.com>
On 04/05/2023 16:14, Cristian Ciocaltea wrote:
>>> + reset-names:
>>> + items:
>>> + - const: phy
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - rockchip,rk3588-otp
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 4
>>> + maxItems: 4
>>> + clock-names:
>>> + items:
>>> + - const: otpc
>>> + - const: apb
>>> + - const: arb
>>> + - const: phy
>>
>> Keep the same order of clocks as in older variants, so you can keep the
>> list in top-level place and here only minItems: 4.
>>
>>> + resets:
>>> + minItems: 1
>>> + maxItems: 3
>>> + reset-names:
>>> + items:
>>> + - const: otpc
>>
>> Shouldn't this be phy?
>
> It seems there is no reset for PHY, or at least I couldn't find any
> reference in the RK3588 TRM, nor in the downstream driver implementation.
OK, just to be sure that this is not the same reset as rk3308 just
differently named in consumer.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-04 14:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 8:43 [PATCH 0/8] Add RK3588 OTP memory support Cristian Ciocaltea
2023-05-01 8:43 ` [PATCH 1/8] dt-bindings: nvmem: Convert rockchip-otp.txt to dt-schema Cristian Ciocaltea
2023-05-02 8:38 ` Heiko Stübner
2023-05-03 6:27 ` Krzysztof Kozlowski
2023-05-01 8:43 ` [PATCH 2/8] dt-bindings: nvmem: rockchip-otp: Add compatible for RK3588 Cristian Ciocaltea
2023-05-02 8:42 ` Heiko Stübner
2023-05-02 12:46 ` Cristian Ciocaltea
2023-05-03 6:28 ` Krzysztof Kozlowski
2023-05-04 14:14 ` Cristian Ciocaltea
2023-05-04 14:39 ` Krzysztof Kozlowski [this message]
2023-05-01 8:43 ` [PATCH 3/8] nvmem: rockchip-otp: Add clocks and reg_read to rockchip_data Cristian Ciocaltea
2023-05-02 8:47 ` Heiko Stübner
2023-05-02 12:49 ` Cristian Ciocaltea
2023-05-01 8:43 ` [PATCH 4/8] nvmem: rockchip-otp: Generalize rockchip_otp_wait_status() Cristian Ciocaltea
2023-05-02 8:48 ` Heiko Stübner
2023-05-01 8:43 ` [PATCH 5/8] nvmem: rockchip-otp: Use devm_reset_control_array_get_exclusive() Cristian Ciocaltea
2023-05-02 8:51 ` Heiko Stübner
2023-05-01 8:43 ` [PATCH 6/8] nvmem: rockchip-otp: Improve probe error handling Cristian Ciocaltea
2023-05-02 8:52 ` Heiko Stübner
2023-05-01 8:43 ` [PATCH 7/8] nvmem: rockchip-otp: Add support for RK3588 Cristian Ciocaltea
2023-05-02 8:55 ` Heiko Stübner
2023-05-01 8:44 ` [PATCH 8/8] arm64: dts: rockchip: Add rk3588 OTP node Cristian Ciocaltea
2023-05-02 8:57 ` Heiko Stübner
2023-05-02 8:26 ` [PATCH 0/8] Add RK3588 OTP memory support Vincent Legoll
2023-05-02 12:40 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2490f7dd-9b6b-2865-4e44-37808b167c11@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®