[PATCH v2] .gitignore: ignore smatch generated files

[PATCH v2] .gitignore: ignore smatch generated files

[Brandon Pollack]

ignore smatch generated files.

Change-Id: I8ca4002128e53024ea8a3daef908ec5e49cec65c
Signed-off-by: Brandon Pollack <brpol@chromium.org>

---
v2: Removed trinity stuff

New to development and looking for tasks to work on to get familiar with
code, I noticed smatch generates some files at the root.  Since this
tool seems frequent for newbies like myself I thought it would be worth
getting rid of the chance of accidentally committing these files.
---
 .gitignore | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/.gitignore b/.gitignore
index 47229f98b327..fd8572cb7db7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -171,3 +171,10 @@ sphinx_*/
 
 # Rust analyzer configuration
 /rust-project.json
+
+# Smatch tree outputs
+smatch_compile.warns
+smatch_db.sqlite
+smatch_warns.txt
+smatch_warns.txt.caller_info
+smatch_warns.txt.sql
-- 
2.40.1.521.gf1e218fcd8-goog

Re: [PATCH v2] .gitignore: ignore smatch generated files

[Dan Carpenter]

On Mon, May 08, 2023 at 05:52:28AM +0000, Brandon Pollack wrote:
> ignore smatch generated files.
> 
> Change-Id: I8ca4002128e53024ea8a3daef908ec5e49cec65c
> Signed-off-by: Brandon Pollack <brpol@chromium.org>

Acked-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter

Re: [PATCH v2] .gitignore: ignore smatch generated files

[Miguel Ojeda]

On Mon, May 8, 2023 at 7:54 AM Brandon Pollack <brpol@chromium.org> wrote:
>
> ignore smatch generated files.

Sorry, I should have mentioned this in v1: this line just repeats the
title -- please also give the rationale for the change in the commit
message, not just what changed.

> Change-Id: I8ca4002128e53024ea8a3daef908ec5e49cec65c

Also, please avoid `Change-Id` (and run `scripts/checkpatch.pl`, which
looks for this sort of things).

Thanks!

Cheers,
Miguel

Re: [PATCH v2] .gitignore: ignore smatch generated files

[Dan Carpenter]

On Mon, May 08, 2023 at 11:29:47AM +0200, Miguel Ojeda wrote:
> On Mon, May 8, 2023 at 7:54 AM Brandon Pollack <brpol@chromium.org> wrote:
> >
> > ignore smatch generated files.
> 
> Sorry, I should have mentioned this in v1: this line just repeats the
> title -- please also give the rationale for the change in the commit
> message, not just what changed.
> 

I secretly wanted to say both things you said.  Also please start the
commit message with a Capital letter.  Here is my proposed commit
message:

The Smatch static checker creates some data files in the kernel root
directory.  Add them to the .gitignore file so that no one accidentally
commits them.

regards,
dan carpenter