* [PATCH] serial: st-asc: fix typo in property name
@ 2023-06-04 8:35 Raphael Gallais-Pou
2023-06-05 12:08 ` Patrice CHOTARD
0 siblings, 1 reply; 2+ messages in thread
From: Raphael Gallais-Pou @ 2023-06-04 8:35 UTC (permalink / raw)
To: Patrice Chotard, Greg Kroah-Hartman, Jiri Slaby
Cc: linux-arm-kernel, linux-serial, linux-kernel
Changes the property name read in the driver according to the YAML.
According to device-tree documentation, property names should not
include underscores.
Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
---
drivers/tty/serial/st-asc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index 5215e6910f68..6ef99a037a9b 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
asc_ports[id].hw_flow_control = of_property_read_bool(np,
"uart-has-rtscts");
- asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1");
+ asc_ports[id].force_m1 = of_property_read_bool(np, "st,force-m1");
asc_ports[id].port.line = id;
asc_ports[id].rts = NULL;
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: st-asc: fix typo in property name
2023-06-04 8:35 [PATCH] serial: st-asc: fix typo in property name Raphael Gallais-Pou
@ 2023-06-05 12:08 ` Patrice CHOTARD
0 siblings, 0 replies; 2+ messages in thread
From: Patrice CHOTARD @ 2023-06-05 12:08 UTC (permalink / raw)
To: Raphael Gallais-Pou, Greg Kroah-Hartman, Jiri Slaby
Cc: linux-arm-kernel, linux-serial, linux-kernel
Hi Raphael
On 6/4/23 10:35, Raphael Gallais-Pou wrote:
> Changes the property name read in the driver according to the YAML.
> According to device-tree documentation, property names should not
> include underscores.
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> drivers/tty/serial/st-asc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index 5215e6910f68..6ef99a037a9b 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>
> asc_ports[id].hw_flow_control = of_property_read_bool(np,
> "uart-has-rtscts");
> - asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1");
> + asc_ports[id].force_m1 = of_property_read_bool(np, "st,force-m1");
> asc_ports[id].port.line = id;
> asc_ports[id].rts = NULL;
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-05 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-04 8:35 [PATCH] serial: st-asc: fix typo in property name Raphael Gallais-Pou
2023-06-05 12:08 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®