* [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description
@ 2023-06-19 7:37 Michal Simek
2023-06-21 14:13 ` Laurent Pinchart
2023-07-10 10:07 ` Michal Simek
0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2023-06-19 7:37 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Harini Katakam, Krzysztof Kozlowski,
Laurent Pinchart, Michael Grzeschik, Parth Gajjar, Piyush Mehta,
Radhey Shyam Pandey, Rob Herring, Robert Hancock, Tanmay Shah,
devicetree, linux-arm-kernel
Based on DT binding dwc_usb3 is single entry without anything else. That's
why combination dwc3_usb3, otg is not allowed. That's why split it to host
and peripheral pair which both points to the same IRQ.
DWC3 code is reading these two properties first before generic dwc_usb3.
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 02cfcc716936..e8104ffc6663 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -888,8 +888,8 @@ dwc3_0: usb@fe200000 {
compatible = "snps,dwc3";
reg = <0x0 0xfe200000 0x0 0x40000>;
interrupt-parent = <&gic>;
- interrupt-names = "dwc_usb3", "otg";
- interrupts = <0 65 4>, <0 69 4>;
+ interrupt-names = "host", "peripheral", "otg";
+ interrupts = <0 65 4>, <0 65 4>, <0 69 4>;
clock-names = "bus_early", "ref";
iommus = <&smmu 0x860>;
snps,quirk-frame-length-adjustment = <0x20>;
@@ -915,8 +915,8 @@ dwc3_1: usb@fe300000 {
compatible = "snps,dwc3";
reg = <0x0 0xfe300000 0x0 0x40000>;
interrupt-parent = <&gic>;
- interrupt-names = "dwc_usb3", "otg";
- interrupts = <0 70 4>, <0 74 4>;
+ interrupt-names = "host", "peripheral", "otg";
+ interrupts = <0 70 4>, <0 70 4>, <0 74 4>;
clock-names = "bus_early", "ref";
iommus = <&smmu 0x861>;
snps,quirk-frame-length-adjustment = <0x20>;
--
2.36.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description
2023-06-19 7:37 [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description Michal Simek
@ 2023-06-21 14:13 ` Laurent Pinchart
2023-07-10 10:53 ` Michal Simek
2023-07-10 10:07 ` Michal Simek
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2023-06-21 14:13 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, michal.simek, git, Conor Dooley,
Harini Katakam, Krzysztof Kozlowski, Michael Grzeschik,
Parth Gajjar, Piyush Mehta, Radhey Shyam Pandey, Rob Herring,
Robert Hancock, Tanmay Shah, devicetree, linux-arm-kernel
Hi Michal,
Thank you for the patch.
On Mon, Jun 19, 2023 at 09:37:54AM +0200, Michal Simek wrote:
> Based on DT binding dwc_usb3 is single entry without anything else. That's
> why combination dwc3_usb3, otg is not allowed. That's why split it to host
> and peripheral pair which both points to the same IRQ.
> DWC3 code is reading these two properties first before generic dwc_usb3.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 02cfcc716936..e8104ffc6663 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -888,8 +888,8 @@ dwc3_0: usb@fe200000 {
> compatible = "snps,dwc3";
> reg = <0x0 0xfe200000 0x0 0x40000>;
> interrupt-parent = <&gic>;
> - interrupt-names = "dwc_usb3", "otg";
> - interrupts = <0 65 4>, <0 69 4>;
> + interrupt-names = "host", "peripheral", "otg";
> + interrupts = <0 65 4>, <0 65 4>, <0 69 4>;
This should read
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
The issue isn't introduced by this patch, so it should probably be fixed
by a separate patch on top, to convert the whole zynqmp.dtsi file. Do
you have any plan to do so, or should I ?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x860>;
> snps,quirk-frame-length-adjustment = <0x20>;
> @@ -915,8 +915,8 @@ dwc3_1: usb@fe300000 {
> compatible = "snps,dwc3";
> reg = <0x0 0xfe300000 0x0 0x40000>;
> interrupt-parent = <&gic>;
> - interrupt-names = "dwc_usb3", "otg";
> - interrupts = <0 70 4>, <0 74 4>;
> + interrupt-names = "host", "peripheral", "otg";
> + interrupts = <0 70 4>, <0 70 4>, <0 74 4>;
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x861>;
> snps,quirk-frame-length-adjustment = <0x20>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description
2023-06-21 14:13 ` Laurent Pinchart
@ 2023-07-10 10:53 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2023-07-10 10:53 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-kernel, monstr, michal.simek, git, Conor Dooley,
Harini Katakam, Krzysztof Kozlowski, Michael Grzeschik,
Parth Gajjar, Piyush Mehta, Radhey Shyam Pandey, Rob Herring,
Robert Hancock, Tanmay Shah, devicetree, linux-arm-kernel
On 6/21/23 16:13, Laurent Pinchart wrote:
> Hi Michal,
>
> Thank you for the patch.
>
> On Mon, Jun 19, 2023 at 09:37:54AM +0200, Michal Simek wrote:
>> Based on DT binding dwc_usb3 is single entry without anything else. That's
>> why combination dwc3_usb3, otg is not allowed. That's why split it to host
>> and peripheral pair which both points to the same IRQ.
>> DWC3 code is reading these two properties first before generic dwc_usb3.
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index 02cfcc716936..e8104ffc6663 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -888,8 +888,8 @@ dwc3_0: usb@fe200000 {
>> compatible = "snps,dwc3";
>> reg = <0x0 0xfe200000 0x0 0x40000>;
>> interrupt-parent = <&gic>;
>> - interrupt-names = "dwc_usb3", "otg";
>> - interrupts = <0 65 4>, <0 69 4>;
>> + interrupt-names = "host", "peripheral", "otg";
>> + interrupts = <0 65 4>, <0 65 4>, <0 69 4>;
>
> This should read
>
> interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>
> The issue isn't introduced by this patch, so it should probably be fixed
> by a separate patch on top, to convert the whole zynqmp.dtsi file. Do
> you have any plan to do so, or should I ?
I have sent it here.
https://lore.kernel.org/r/9d5bd17f37772be186cab17b06cc21351d36ff62.1688986332.git.michal.simek@amd.com
Feel free to review it.
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description
2023-06-19 7:37 [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description Michal Simek
2023-06-21 14:13 ` Laurent Pinchart
@ 2023-07-10 10:07 ` Michal Simek
1 sibling, 0 replies; 4+ messages in thread
From: Michal Simek @ 2023-07-10 10:07 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Conor Dooley, Harini Katakam, Krzysztof Kozlowski,
Laurent Pinchart, Michael Grzeschik, Parth Gajjar, Piyush Mehta,
Radhey Shyam Pandey, Rob Herring, Robert Hancock, Tanmay Shah,
devicetree, linux-arm-kernel
On 6/19/23 09:37, Michal Simek wrote:
> Based on DT binding dwc_usb3 is single entry without anything else. That's
> why combination dwc3_usb3, otg is not allowed. That's why split it to host
> and peripheral pair which both points to the same IRQ.
> DWC3 code is reading these two properties first before generic dwc_usb3.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 02cfcc716936..e8104ffc6663 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -888,8 +888,8 @@ dwc3_0: usb@fe200000 {
> compatible = "snps,dwc3";
> reg = <0x0 0xfe200000 0x0 0x40000>;
> interrupt-parent = <&gic>;
> - interrupt-names = "dwc_usb3", "otg";
> - interrupts = <0 65 4>, <0 69 4>;
> + interrupt-names = "host", "peripheral", "otg";
> + interrupts = <0 65 4>, <0 65 4>, <0 69 4>;
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x860>;
> snps,quirk-frame-length-adjustment = <0x20>;
> @@ -915,8 +915,8 @@ dwc3_1: usb@fe300000 {
> compatible = "snps,dwc3";
> reg = <0x0 0xfe300000 0x0 0x40000>;
> interrupt-parent = <&gic>;
> - interrupt-names = "dwc_usb3", "otg";
> - interrupts = <0 70 4>, <0 74 4>;
> + interrupt-names = "host", "peripheral", "otg";
> + interrupts = <0 70 4>, <0 70 4>, <0 74 4>;
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x861>;
> snps,quirk-frame-length-adjustment = <0x20>;
Applied.
M
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-10 10:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-19 7:37 [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description Michal Simek
2023-06-21 14:13 ` Laurent Pinchart
2023-07-10 10:53 ` Michal Simek
2023-07-10 10:07 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®