[PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap_resource()
@ 2023-07-04 10:18 Yangtao Li
  2023-07-04 10:18 ` [PATCH 2/5] EDAC/dmc520: " Yangtao Li
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Yangtao Li @ 2023-07-04 10:18 UTC (permalink / raw)
  To: Shravan Kumar Ramani, Borislav Petkov, Tony Luck, James Morse,
	Mauro Carvalho Chehab, Robert Richter
  Cc: Yangtao Li, linux-edac, linux-kernel

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/edac/bluefield_edac.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/edac/bluefield_edac.c b/drivers/edac/bluefield_edac.c
index e4736eb37bfb..0d09add30460 100644
--- a/drivers/edac/bluefield_edac.c
+++ b/drivers/edac/bluefield_edac.c
@@ -245,7 +245,6 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct edac_mc_layer layers[1];
 	struct mem_ctl_info *mci;
-	struct resource *emi_res;
 	unsigned int mc_idx, dimm_count;
 	int rc, ret;
 
@@ -266,10 +265,6 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	emi_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!emi_res)
-		return -EINVAL;
-
 	layers[0].type = EDAC_MC_LAYER_SLOT;
 	layers[0].size = dimm_count;
 	layers[0].is_virt_csrow = true;
@@ -281,7 +276,7 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev)
 	priv = mci->pvt_info;
 
 	priv->dimm_per_mc = dimm_count;
-	priv->emi_base = devm_ioremap_resource(dev, emi_res);
+	priv->emi_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(priv->emi_base)) {
 		dev_err(dev, "failed to map EMI IO resource\n");
 		ret = PTR_ERR(priv->emi_base);
-- 
2.39.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/5] EDAC/dmc520: Convert to devm_platform_ioremap_resource()
  2023-07-04 10:18 [PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap_resource() Yangtao Li
@ 2023-07-04 10:18 ` Yangtao Li
  2023-07-04 10:18 ` [PATCH 3/5] EDAC/synopsys: " Yangtao Li
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Yangtao Li @ 2023-07-04 10:18 UTC (permalink / raw)
  To: Lei Wang, Borislav Petkov, Tony Luck, James Morse,
	Mauro Carvalho Chehab, Robert Richter
  Cc: Yangtao Li, linux-edac, linux-kernel

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/edac/dmc520_edac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c
index 1fa5ca57e9ec..9a3ebf214387 100644
--- a/drivers/edac/dmc520_edac.c
+++ b/drivers/edac/dmc520_edac.c
@@ -480,7 +480,6 @@ static int dmc520_edac_probe(struct platform_device *pdev)
 	struct mem_ctl_info *mci;
 	void __iomem *reg_base;
 	u32 irq_mask_all = 0;
-	struct resource *res;
 	struct device *dev;
 	int ret, idx, irq;
 	u32 reg_val;
@@ -505,8 +504,7 @@ static int dmc520_edac_probe(struct platform_device *pdev)
 	}
 
 	/* Initialize dmc520 edac */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg_base = devm_ioremap_resource(dev, res);
+	reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(reg_base))
 		return PTR_ERR(reg_base);
 
-- 
2.39.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 3/5] EDAC/synopsys: Convert to devm_platform_ioremap_resource()
  2023-07-04 10:18 [PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap_resource() Yangtao Li
  2023-07-04 10:18 ` [PATCH 2/5] EDAC/dmc520: " Yangtao Li
@ 2023-07-04 10:18 ` Yangtao Li
  2023-07-04 12:17   ` Michal Simek
  2023-07-04 10:18 ` [PATCH 4/5] EDAC/ti: " Yangtao Li
  2023-07-04 10:18 ` [PATCH 5/5] EDAC/xgene: " Yangtao Li
  3 siblings, 1 reply; 7+ messages in thread
From: Yangtao Li @ 2023-07-04 10:18 UTC (permalink / raw)
  To: Michal Simek, Borislav Petkov, Tony Luck, James Morse,
	Mauro Carvalho Chehab, Robert Richter
  Cc: Yangtao Li, linux-arm-kernel, linux-edac, linux-kernel

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/edac/synopsys_edac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index f7d37c282819..620861fb5231 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -1325,11 +1325,9 @@ static int mc_probe(struct platform_device *pdev)
 	struct synps_edac_priv *priv;
 	struct mem_ctl_info *mci;
 	void __iomem *baseaddr;
-	struct resource *res;
 	int rc;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	baseaddr = devm_ioremap_resource(&pdev->dev, res);
+	baseaddr = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(baseaddr))
 		return PTR_ERR(baseaddr);
 
-- 
2.39.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/5] EDAC/synopsys: Convert to devm_platform_ioremap_resource()
  2023-07-04 10:18 ` [PATCH 3/5] EDAC/synopsys: " Yangtao Li
@ 2023-07-04 12:17   ` Michal Simek
  2024-01-23 13:57     ` Borislav Petkov
  0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2023-07-04 12:17 UTC (permalink / raw)
  To: Yangtao Li, Borislav Petkov, Tony Luck, James Morse,
	Mauro Carvalho Chehab, Robert Richter
  Cc: linux-arm-kernel, linux-edac, linux-kernel



On 7/4/23 12:18, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   drivers/edac/synopsys_edac.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> index f7d37c282819..620861fb5231 100644
> --- a/drivers/edac/synopsys_edac.c
> +++ b/drivers/edac/synopsys_edac.c
> @@ -1325,11 +1325,9 @@ static int mc_probe(struct platform_device *pdev)
>   	struct synps_edac_priv *priv;
>   	struct mem_ctl_info *mci;
>   	void __iomem *baseaddr;
> -	struct resource *res;
>   	int rc;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	baseaddr = devm_ioremap_resource(&pdev->dev, res);
> +	baseaddr = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(baseaddr))
>   		return PTR_ERR(baseaddr);
>   

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/5] EDAC/synopsys: Convert to devm_platform_ioremap_resource()
  2023-07-04 12:17   ` Michal Simek
@ 2024-01-23 13:57     ` Borislav Petkov
  0 siblings, 0 replies; 7+ messages in thread
From: Borislav Petkov @ 2024-01-23 13:57 UTC (permalink / raw)
  To: Michal Simek, Yangtao Li
  Cc: Tony Luck, James Morse, Mauro Carvalho Chehab, Robert Richter,
	linux-arm-kernel, linux-edac, linux-kernel

On Tue, Jul 04, 2023 at 02:17:09PM +0200, Michal Simek wrote:
> On 7/4/23 12:18, Yangtao Li wrote:
> > Use devm_platform_ioremap_resource() to simplify code.
> > 
> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> > ---
> >   drivers/edac/synopsys_edac.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> > index f7d37c282819..620861fb5231 100644
> > --- a/drivers/edac/synopsys_edac.c
> > +++ b/drivers/edac/synopsys_edac.c
> > @@ -1325,11 +1325,9 @@ static int mc_probe(struct platform_device *pdev)
> >   	struct synps_edac_priv *priv;
> >   	struct mem_ctl_info *mci;
> >   	void __iomem *baseaddr;
> > -	struct resource *res;
> >   	int rc;
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	baseaddr = devm_ioremap_resource(&pdev->dev, res);
> > +	baseaddr = devm_platform_ioremap_resource(pdev, 0);
> >   	if (IS_ERR(baseaddr))
> >   		return PTR_ERR(baseaddr);
> 
> Reviewed-by: Michal Simek <michal.simek@amd.com>

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 4/5] EDAC/ti: Convert to devm_platform_ioremap_resource()
  2023-07-04 10:18 [PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap_resource() Yangtao Li
  2023-07-04 10:18 ` [PATCH 2/5] EDAC/dmc520: " Yangtao Li
  2023-07-04 10:18 ` [PATCH 3/5] EDAC/synopsys: " Yangtao Li
@ 2023-07-04 10:18 ` Yangtao Li
  2023-07-04 10:18 ` [PATCH 5/5] EDAC/xgene: " Yangtao Li
  3 siblings, 0 replies; 7+ messages in thread
From: Yangtao Li @ 2023-07-04 10:18 UTC (permalink / raw)
  To: Tero Kristo, Borislav Petkov, Tony Luck, James Morse,
	Mauro Carvalho Chehab, Robert Richter
  Cc: Yangtao Li, linux-edac, linux-kernel

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/edac/ti_edac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
index 6971ded598de..deec2d045e8c 100644
--- a/drivers/edac/ti_edac.c
+++ b/drivers/edac/ti_edac.c
@@ -231,7 +231,6 @@ static int ti_edac_probe(struct platform_device *pdev)
 {
 	int error_irq = 0, ret = -ENODEV;
 	struct device *dev = &pdev->dev;
-	struct resource *res;
 	void __iomem *reg;
 	struct mem_ctl_info *mci;
 	struct edac_mc_layer layers[1];
@@ -243,8 +242,7 @@ static int ti_edac_probe(struct platform_device *pdev)
 	if (!id)
 		return -ENODEV;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg = devm_ioremap_resource(dev, res);
+	reg = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(reg))
 		return PTR_ERR(reg);
 
-- 
2.39.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 5/5] EDAC/xgene: Convert to devm_platform_ioremap_resource()
  2023-07-04 10:18 [PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap_resource() Yangtao Li
                   ` (2 preceding siblings ...)
  2023-07-04 10:18 ` [PATCH 4/5] EDAC/ti: " Yangtao Li
@ 2023-07-04 10:18 ` Yangtao Li
  3 siblings, 0 replies; 7+ messages in thread
From: Yangtao Li @ 2023-07-04 10:18 UTC (permalink / raw)
  To: Khuong Dinh, Borislav Petkov, Tony Luck, James Morse,
	Mauro Carvalho Chehab, Robert Richter
  Cc: Yangtao Li, linux-edac, linux-kernel

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/edac/xgene_edac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
index c52b9dd9154c..5ac1a0d3495b 100644
--- a/drivers/edac/xgene_edac.c
+++ b/drivers/edac/xgene_edac.c
@@ -1845,7 +1845,6 @@ static int xgene_edac_probe(struct platform_device *pdev)
 {
 	struct xgene_edac *edac;
 	struct device_node *child;
-	struct resource *res;
 	int rc;
 
 	edac = devm_kzalloc(&pdev->dev, sizeof(*edac), GFP_KERNEL);
@@ -1903,8 +1902,7 @@ static int xgene_edac_probe(struct platform_device *pdev)
 		edac->rb_map = NULL;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	edac->pcp_csr = devm_ioremap_resource(&pdev->dev, res);
+	edac->pcp_csr = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(edac->pcp_csr)) {
 		dev_err(&pdev->dev, "no PCP resource address\n");
 		rc = PTR_ERR(edac->pcp_csr);
-- 
2.39.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-01-23 13:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-04 10:18 [PATCH 1/5] EDAC, mellanox: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-04 10:18 ` [PATCH 2/5] EDAC/dmc520: " Yangtao Li
2023-07-04 10:18 ` [PATCH 3/5] EDAC/synopsys: " Yangtao Li
2023-07-04 12:17   ` Michal Simek
2024-01-23 13:57     ` Borislav Petkov
2023-07-04 10:18 ` [PATCH 4/5] EDAC/ti: " Yangtao Li
2023-07-04 10:18 ` [PATCH 5/5] EDAC/xgene: " Yangtao Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®