mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Natikar Basavaraj <Basavaraj.Natikar@amd.com>,
	S-k Shyam-sundar <Shyam-sundar.S-k@amd.com>,
	<linus.walleij@linaro.org>
Cc: <andriy.shevchenko@linux.intel.com>, <npliashechnikov@gmail.com>,
	<nmschulte@gmail.com>, <friedrich.vock@gmx.de>,
	<dridri85@gmail.com>, "Hans de Goede" <hdegoede@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list" <linux-gpio@vger.kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v2 0/4] Fix for interrupt storm on ASUS TUF A16
Date: Wed, 5 Jul 2023 08:30:01 -0500	[thread overview]
Message-ID: <20230705133005.577-1-mario.limonciello@amd.com> (raw)

An interrupt storm is reported for the GPIO controller on ASUS TUF A16
but only on Linux.  In comparing the GPIO registers from Windows and
Linux the configuration for several bits specified in _AEI() was never
actually loaded into the hardware on Linux.

This meant that many values were taking the default hardware strapping
for pull up/pull down.

This series reworks the programming of various bits to unify the
expectations for the hardware.

It's confirmed to fix the interrupt storm on this system.
This series is based off of the tag pinctrl-v6.5-1.

v1->v2:
 * Update for Andy's feedback

Mario Limonciello (4):
  pinctrl: amd: Only use special debounce behavior for GPIO 0
  pinctrl: amd: Use amd_pinconf_set() for all config options
  pinctrl: amd: Drop pull up select configuration
  pinctrl: amd: Unify debounce handling into amd_pinconf_set()

 drivers/pinctrl/pinctrl-amd.c | 61 +++++++++++++----------------------
 drivers/pinctrl/pinctrl-amd.h |  1 -
 2 files changed, 23 insertions(+), 39 deletions(-)

base-commit: 9f0648f13e34a01f2e1a7a0d5801988a7bca6988
-- 
2.34.1


             reply	other threads:[~2023-07-05 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 13:30 Mario Limonciello [this message]
2023-07-05 13:30 ` [PATCH v2 1/4] pinctrl: amd: Only use special debounce behavior for GPIO 0 Mario Limonciello
2023-07-05 13:30 ` [PATCH v2 2/4] pinctrl: amd: Use amd_pinconf_set() for all config options Mario Limonciello
2023-07-06  9:16   ` Andy Shevchenko
2023-07-06 14:30     ` Limonciello, Mario
2023-07-05 13:30 ` [PATCH v2 3/4] pinctrl: amd: Drop pull up select configuration Mario Limonciello
2023-07-05 13:30 ` [PATCH v2 4/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set() Mario Limonciello
2023-07-07 13:50 ` [PATCH v2 0/4] Fix for interrupt storm on ASUS TUF A16 Linus Walleij
2023-07-07 14:09   ` Limonciello, Mario
2023-07-10 17:49     ` Jan Visser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230705133005.577-1-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dridri85@gmail.com \
    --cc=friedrich.vock@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nmschulte@gmail.com \
    --cc=npliashechnikov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®